Bug #17614

No automatic upgrade from N~rc1 to N

Added by sajolida 2020-04-14 15:11:38 . Updated 2020-05-18 10:01:45 .

Status:
Needs Validation
Priority:
Elevated
Assignee:
CyrilBrulebois
Category:
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
bugfix/17614-automatic-upgrade-from-rc
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Upgrader
Deliverable for:

Description

We already received 2 such reports on tails-testers:

The first report from April 8 is still unanswered so I’m creating this ticket to make sure that it’s not falling into the cracks. According to /news/version_3.9.html, automatic upgrade should be provided from rc1 to the final version. Though I haven’t tested it.


Subtasks


History

#1 Updated by intrigeri 2020-04-14 15:36:09

  • Status changed from New to Confirmed
  • Assignee set to CyrilBrulebois
  • Priority changed from Normal to Elevated

Thank you for reporting this on Redmine. My email backlog is ugly so this does help!

I’ve reproduced this. In the Journal I see tails-upgrade-frontend-wrapper[8897]: The system is up-to-date.

First, I think this only affects systems that were initially installed with 4.5~rc1: in the v2 upgrade scheme, what matters is not the version a user is running, but which version they initially installed (unless, of course, the Upgrader got broken in 4.5~rc1, but since 4.4.x, its code only changed wrt. generation of IUKs, which is out of scope as far as this issues is concerned).

I believe that’s because of the combination of:

  • /etc/os-release in 4.5~rc1 (correctly) says TAILS_CHANNEL="alpha"
  • wiki/src/upgrade/v2/Tails/4.5~rc1/amd64/alpha/upgrades.yml advertises no upgrade (feels wrong to me)

So I think we need to do 2 things:

  • Short-term: make wiki/src/upgrade/v2/Tails/4.5~rc1/amd64/alpha/upgrades.yml advertise the upgrade to 4.5 ← @CyrilBrulebois, can you please take care of this? Once this is done, please reassign to me for the long-term fix:
  • Long-term: fix our release process so this does not happen again. I probably broke this part myself and I’m happy to fix it. Note that next time this problem can happen again is in a few months, so if needed I’ll postpone this a little bit.

#2 Updated by CyrilBrulebois 2020-04-18 00:42:37

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|c7e03cc332ad6b93e71360f2c661236408328e8f.

#3 Updated by CyrilBrulebois 2020-04-18 01:04:58

  • Assignee changed from CyrilBrulebois to intrigeri
  • Priority changed from Elevated to High

Fixed this way:

sed '/^channel:/s/stable/alpha/'                                   \
    < wiki/src/upgrade/v2/Tails/4.5~rc1/amd64/stable/upgrades.yml  \
    > wiki/src/upgrade/v2/Tails/4.5~rc1/amd64/alpha/upgrades.yml

gpg --armor --default-key "${TAILS_SIGNATURE_KEY:?}" --detach-sign \
    wiki/src/upgrade/v2/Tails/4.5~rc1/amd64/alpha/upgrades.yml

mv  wiki/src/upgrade/v2/Tails/4.5~rc1/amd64/alpha/upgrades.yml.asc \
    wiki/src/upgrade/v2/Tails/4.5~rc1/amd64/alpha/upgrades.yml.pgp

Problem confirmed before and fixed after the push: 4.5~rc1 gets a prompt to upgrade, and 4.5 is happy to be the latest version.

Lowering priority a bit and reassigning to @intrigeri for the doc part.

#4 Updated by intrigeri 2020-04-22 14:37:22

  • Priority changed from High to Elevated
  • Target version changed from Tails_4.6 to Tails_4.7
  • Type of work changed from Test to Contributors documentation

#5 Updated by intrigeri 2020-05-18 09:53:52

  • Subject changed from No automatic upgrade from 4.5~rc1 to 4.5 to No automatic upgrade from N~rc1 to N
  • Feature Branch set to bugfix/17614-automatic-upgrade-from-rc

#6 Updated by intrigeri 2020-05-18 10:01:45

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to CyrilBrulebois
  • Type of work changed from Contributors documentation to Code

Hi @CyrilBrulebois,

Simplified, partial local testing works fine ⇒ please review and merge if happy :)