Bug #17603

Test suite: “Chatting with some friend over XMPP” failures

Added by CyrilBrulebois 2020-04-07 14:24:23 . Updated 2020-04-16 08:50:44 .

Status:
Confirmed
Priority:
Normal
Assignee:
anonym
Category:
Test suite
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Checking locally the whole scenarios that had at least one test failure in Jenkins, I’m seeing repeated issues for the “Chatting with some friend over XMPP” test, be it on stretch or on buster (so I suppose this isn’t specific to a particular release).

It might be that the credentials helpfully shared by @anonym a while ago are not working properly anymore, but I thought I’d make sure by filing this ticket instead of assuming anything. Also, I think we should move on with publishing 4.5 sooner rather than later, so I won’t spend time trying to manually test this right away.

  @check_tor_leaks
  Scenario: Chatting with some friend over XMPP                                    # features/pidgin.feature:17
    Given I have started Tails from DVD and logged in and the network is connected # features/step_definitions/snapshots.rb:170
    When I start "Pidgin Internet Messenger" via GNOME Activities Overview         # features/step_definitions/common_steps.rb:685
    Then I see Pidgin's account manager window                                     # features/step_definitions/pidgin.rb:300
    When I create my XMPP account                                                  # features/step_definitions/pidgin.rb:74
    And I close Pidgin's account manager window                                    # features/step_definitions/pidgin.rb:304
    Then Pidgin automatically enables my XMPP account                              # features/step_definitions/pidgin.rb:99
    Given my XMPP friend goes online                                               # features/step_definitions/pidgin.rb:109
      cannot find PidginFriendOnline.png on the screen (FindFailed)
      ./features/support/helpers/screen.rb:137:in `rescue in wait'
      ./features/support/helpers/screen.rb:131:in `wait'
      ./features/step_definitions/pidgin.rb:121:in `/^my XMPP friend goes online( and joins the multi-user chat)?$/'
      features/pidgin.feature:24:in `Given my XMPP friend goes online'
    When I start a conversation with my friend                                     # features/step_definitions/pidgin.rb:124
    And I say something to my friend                                               # features/step_definitions/pidgin.rb:139
    Then I receive a response from my friend                                       # features/step_definitions/pidgin.rb:150
      Scenario failed at time 00:09:18

From a very quick look at the screenshot, it might be that some spammer/“friend” got an authorization requested in the queue, which might be interfering.

A bit further down the line, I’m seeing those messages as well, maybe some error case might be improved?

  @check_tor_leaks
  Scenario: Chatting with some friend over XMPP in a multi-user chat                                   # features/pidgin.feature:30
    Given I have started Tails from DVD and logged in and the network is connected                     # features/step_definitions/snapshots.rb:170
    When I start "Pidgin Internet Messenger" via GNOME Activities Overview                             # features/step_definitions/common_steps.rb:685
    Then I see Pidgin's account manager window                                                         # features/step_definitions/pidgin.rb:300
    When I create my XMPP account                                                                      # features/step_definitions/pidgin.rb:74
    And I close Pidgin's account manager window                                                        # features/step_definitions/pidgin.rb:304
    Then Pidgin automatically enables my XMPP account                                                  # features/step_definitions/pidgin.rb:99
    When I join some empty multi-user chat                                                             # features/step_definitions/pidgin.rb:184
    And I clear the multi-user chat's scrollback                                                       # features/step_definitions/pidgin.rb:225
Traceback (most recent call last):
  File "/home/kibi/work/clients/tails/release/release-checkout/features/scripts/otr-bot.py", line 205, in <module>
    otr_bot.join_room(room)
  File "/usr/lib/python2.7/dist-packages/jabberbot.py", line 257, in join_room
    self.connect().send(pres)
AttributeError: 'NoneType' object has no attribute 'send'
    And my XMPP friend goes online and joins the multi-user chat                                       # features/step_definitions/pidgin.rb:109
      cannot find PidginFriendOnline.png on the screen (FindFailed)
      ./features/support/helpers/screen.rb:137:in `rescue in wait'
      ./features/support/helpers/screen.rb:131:in `wait'
      ./features/step_definitions/pidgin.rb:121:in `/^my XMPP friend goes online( and joins the multi-user chat)?$/'
      features/pidgin.feature:39:in `And my XMPP friend goes online and joins the multi-user chat'
    Then I can see that my friend joined the multi-user chat                                           # features/step_definitions/pidgin.rb:231
    And I say something to my friend in the multi-user chat                                            # features/step_definitions/pidgin.rb:139
    Then I receive a response from my friend in the multi-user chat                                    # features/step_definitions/pidgin.rb:150
    When I say https://labs.riseup.net/code/projects/tails/roadmap to my friend in the multi-user chat # features/step_definitions/pidgin.rb:139
    Then I see the Tails roadmap URL                                                                   # features/step_definitions/pidgin.rb:460
    When I wait 10 seconds                                                                             # features/step_definitions/common_steps.rb:882
    And I click on the Tails roadmap URL                                                               # features/step_definitions/pidgin.rb:474
    Then the Tor Browser loads the Tails roadmap                                                       # features/step_definitions/common_steps.rb:417
      Scenario failed at time 00:11:24

Tentatively assigning to @anonym who might be the most efficient person to triage this (having shared credentials in the first place, and being somewhat knowledgeable about the test suite — to say the list). ;)


Subtasks


History

#1 Updated by intrigeri 2020-04-15 15:07:33

> Tentatively assigning to @anonym who might be the most efficient person to triage this (having shared credentials in the first place, and being somewhat knowledgeable about the test suite — to say the list). ;)

I suspect sharing credentials may be problematic here, in terms of
robustness, if several people run the test suite with the same
credentials at the same time. Could be totally wrong though!

#2 Updated by anonym 2020-04-16 08:50:44

intrigeri wrote:
> > Tentatively assigning to anonym who might be the most efficient person to triage this (having shared credentials in the first place, and being somewhat knowledgeable about the test suite — to say the list). ;)
>
> I suspect sharing credentials may be problematic here, in terms of
> robustness, if several people run the test suite with the same
> credentials at the same time. Could be totally wrong though!

This is correct! However, the time window for such a clash is so small I don’t think it can explain “repeated issues” with this scenario.