Bug #17596

Test suite: XDG_SESSION_TYPE: unbound variable

Added by CyrilBrulebois 2020-04-06 15:08:27 . Updated 2020-05-12 07:00:21 .

Status:
Needs Validation
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_4.7
Start date:
Due date:
% Done:

0%

Feature Branch:
test/17596-support-unset-XDG_SESSION_TYPE
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Tentatively assigning to @anonym, who drove almost all the way out of sikuli/java/etc. (thanks!).

I had seen this when SSH-ing from a stretch box to another one, but I’m now also seeing it locally on a stretch box which runs Xfce:

./run_test_suite: line 273: XDG_SESSION_TYPE: unbound variable

Would it be safe to assume that any desktop environment that would be running Wayland would advertise it through XDG_SESSION_TYPE, and that this variable’s not being set could be considered as if one was running under X11?

For now, setting XDG_SESSION_TYPE=x11 somewhere between sudo and ./run_test_suite does the trick, but it would be a tad more welcoming to new test suite users to have a slightly less abrupt return when that variable isn’t set at all?

Subtasks

History

#1 Updated by intrigeri 2020-04-16 10:29:27

> Would it be safe to assume that any desktop environment that would be running Wayland would advertise it through XDG_SESSION_TYPE, and that this variable’s not being set could be considered as if one was running under X11?

I suspect some of the lightweight Wayland compositors, meant for folks who want to carefully assemble their own desktop environment from various Lego parts, might not care much about setting XDG_SESSION_TYPE, or about anything XDG in general.

Still, I think your proposal is good enough: worst case, users of such a Wayland compositor will get a mostly informative error message from xtightvncviewer.

#2 Updated by CyrilBrulebois 2020-04-17 23:49:19

I’m feeling a bit stupid now because the proposed workaround actually highlights the biggest issue: XDG_SESSION_TYPE=x11 is actually set in my unprivileged user’s environment under XFCE, but that’s filtered out by sudo…

#3 Updated by intrigeri 2020-05-11 16:24:12

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to intrigeri
  • Feature Branch set to test/17596-support-unset-XDG_SESSION_TYPE

I’ve been hit by this and made interesting discovery while testing the various failure modes — stay tuned!

#4 Updated by intrigeri 2020-05-11 16:43:54

  • Status changed from In Progress to Needs Validation
  • Target version set to Tails_4.7

#5 Updated by CyrilBrulebois 2020-05-11 17:01:43

The explanations in the commit message look good to me, thanks!

#6 Updated by intrigeri 2020-05-12 07:00:21

  • Assignee deleted (intrigeri)

This does not break on Jenkins ⇒ please review and merge into stable :)