Test suite produces obsoletion warnings with Ruby 2.7
On Bullseye/Sid we see stuff like:
features/support/helpers/vm_helper.rb:433: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call features/support/helpers/remote_shell.rb:79: warning: The called method `initialize' is defined here features/support/helpers/misc_helpers.rb:356: warning: constant ::Fixnum is deprecated
which we should fix to avoid warning fatigue.
#2 Updated by anonym 2020-03-25 14:47:11
- % Done changed from 0 to 30
- Feature Branch set to test/17552-fix-ruby-2.7-obsoletion-warnings
I haven’t managed a full run with ruby 2.7 yet, so these fixes might be incomplete. I just want to make sure I’m not breaking anything so far, particularly on Stretch, so let’s see what Jenkins thinks!
#5 Updated by intrigeri 2020-04-04 06:58:41
- Target version changed from Tails_4.5 to Tails_4.6
On Jenkins, “The Tor Browser cannot access the LAN” always fails with:
wrong number of arguments (given 1, expected 2) (ArgumentError) ./features/support/helpers/firewall_helper.rb:115:in `assert_no_connections' ./features/step_definitions/torified_browsing.rb:2:in `/^no traffic was sent to the web server on the LAN$/' features/torified_browsing.feature:15:in `And no traffic was sent to the web server on the LAN'
#8 Updated by anonym 2020-04-08 10:36:18
- Status changed from In Progress to Needs Validation
- Assignee deleted (
- % Done changed from 30 to 50
> intrigeri wrote:
> > On Jenkins, “The Tor Browser cannot access the LAN” always fails with:
> Fixed in commit:39001a20541131e1ce44f417a65f5c6cf162e909. I think all will be good in the next run on Jenkins.
Yes, looks good now!