Bug #17552

Test suite produces obsoletion warnings with Ruby 2.7

Added by anonym 2020-03-25 13:49:08 . Updated 2020-04-12 13:34:02 .

Status:
Resolved
Priority:
Normal
Assignee:
segfault
Category:
Test suite
Target version:
Tails_4.6
Start date:
Due date:
% Done:

50%

Feature Branch:
test/17552-fix-ruby-2.7-obsoletion-warnings
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

On Bullseye/Sid we see stuff like:

features/support/helpers/vm_helper.rb:433: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
features/support/helpers/remote_shell.rb:79: warning: The called method `initialize' is defined here
features/support/helpers/misc_helpers.rb:356: warning: constant ::Fixnum is deprecated


which we should fix to avoid warning fatigue.

Subtasks

Related issues

Related to Tails - Bug #15460: Test suite broken with Java 9+ so we need to replace Sikuli Resolved
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by anonym 2020-03-25 14:46:10

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|5d87fa110dca8a47678152be1705f2ecb9c5c821.

#2 Updated by anonym 2020-03-25 14:47:11

  • % Done changed from 0 to 30
  • Feature Branch set to test/17552-fix-ruby-2.7-obsoletion-warnings

I haven’t managed a full run with ruby 2.7 yet, so these fixes might be incomplete. I just want to make sure I’m not breaking anything so far, particularly on Stretch, so let’s see what Jenkins thinks!

#3 Updated by intrigeri 2020-03-26 08:42:17

  • related to Bug #15460: Test suite broken with Java 9+ so we need to replace Sikuli added

#4 Updated by intrigeri 2020-04-03 08:10:41

#5 Updated by intrigeri 2020-04-04 06:58:41

  • Target version changed from Tails_4.5 to Tails_4.6

On Jenkins, “The Tor Browser cannot access the LAN” always fails with:

wrong number of arguments (given 1, expected 2) (ArgumentError)
./features/support/helpers/firewall_helper.rb:115:in `assert_no_connections'
./features/step_definitions/torified_browsing.rb:2:in `/^no traffic was sent to the web server on the LAN$/'
features/torified_browsing.feature:15:in `And no traffic was sent to the web server on the LAN'

#6 Updated by anonym 2020-04-07 11:56:56

  • Target version changed from Tails_4.6 to Tails_4.5

intrigeri wrote:
> On Jenkins, “The Tor Browser cannot access the LAN” always fails with:

Fixed in commit:39001a20541131e1ce44f417a65f5c6cf162e909. I think all will be good in the next run on Jenkins.

#7 Updated by CyrilBrulebois 2020-04-07 17:05:24

  • Target version changed from Tails_4.5 to Tails_4.6

#8 Updated by anonym 2020-04-08 10:36:18

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (anonym)
  • % Done changed from 30 to 50

anonym wrote:
> intrigeri wrote:
> > On Jenkins, “The Tor Browser cannot access the LAN” always fails with:
>
> Fixed in commit:39001a20541131e1ce44f417a65f5c6cf162e909. I think all will be good in the next run on Jenkins.

Yes, looks good now!

#9 Updated by segfault 2020-04-12 12:46:14

  • Assignee set to segfault

#10 Updated by anonym 2020-04-12 12:52:07

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|8a562e260419b9bc198241c4178fb43db50af1cc.

#11 Updated by intrigeri 2020-04-12 13:23:57

  • Status changed from In Progress to Needs Validation

#12 Updated by segfault 2020-04-12 13:34:02

  • Status changed from Needs Validation to Resolved