Feature #17515

Allow translators to upload .po files, adding the new strings as suggestions

Added by emmapeel 2020-03-10 11:46:52 . Updated 2020-04-24 13:03:33 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Sysadmin
Blueprint:

Starter:
0
Affected tool:
Translation Platform
Deliverable for:

Description

So, the platform renders slowly. Also, translators can have translation programs in local, like POEdit, that make their work easier.

The possiblity of uploading translation is a MUST for many contributors.

And in Weblate, this can be fine-grained, so for example, a translator can upload a file and add the new translations as suggestions. You can download the file, make your changes, and then upload again.

This is very useful, has no difference in risk to the current setup, and saves a lot of time to the translators. I have used this feature a lot, although it is not available for translators at the moment. Italian and Chinese translators have asked for this feature.

It also saves traffic on the webserver, as you dont need to render a lot of CSS and related queries for each string.


Subtasks


History

#1 Updated by emmapeel 2020-03-10 12:11:29

  • Subject changed from Allow translators to upload .po files, adding the translations as suggestions to Allow translators to upload .po files, adding the new strings as suggestions

#2 Updated by intrigeri 2020-03-28 10:24:04

Assuming I understood correctly that we can enforce, via Weblate configuration, that all such uploaded strings are treated as suggestions: I wholeheartedly support this proposal.

#3 Updated by emmapeel 2020-03-30 08:24:25

I have enabled ‘Upload translations’ for the Tails User role. This is a role for all registered users.

As this user cannot save translations, the strings on the uploaded file can only be proposed as suggestions.

Reviewers have more powers, and so when presented with the form, they also get to:

- Add as needing review — we are not using this review thing

- add as approved translation

- add as suggestion
- add as needing edit

I have taken out the power of ‘overwrite existing translations’ from the Reviewers role. I don’t think this is needed for reviewers. Also, you can add as suggestion and go one by one, but I felt the ability to screw up and not realising was just too much.

#4 Updated by intrigeri 2020-04-19 05:59:00

  • Status changed from Confirmed to Resolved

Hi!

> I have enabled ‘Upload translations’ for the Tails User role. This is a role for all registered users.

Thank you!

> As this user cannot save translations, the strings on the uploaded file can only be proposed as suggestions.

Great.

> Reviewers have more powers, and so when presented with the form, they also get to:
> […]
> - add as approved translation

That’s unfortunate, but consistent with what we already had (as per https://tails.boum.org/contribute/design/translation_platform/#access-control, “Technically, reviewers are also allowed to directly save new translations of their own, edit existing translations, and accept their own suggestions; we ask them in our documentation to use this privilege sparingly, only to fix important and obvious problems”).

I’ve checked the design doc and found nothing that needs updating wrt. this access control change ⇒ closing!

> I have taken out the power of ‘overwrite existing translations’ from the Reviewers role. I don’t think this is needed for reviewers. Also, you can add as suggestion and go one by one, but I felt the ability to screw up and not realising was just too much.

Putting “upload translations” aside, it is my understanding that at some point, we wanted Reviewers to be able to quickly fix breakage introduced by other translators, hence the “overwrite” permission. I totally trust you to figure out the best trade off between “enabling trusted folks to fix problems” and “the risk that they mess up”. And if folks later complain about this change, we can reconsider and iterate! :)

#5 Updated by emmapeel 2020-04-19 11:46:21

intrigeri wrote:
> > I have taken out the power of ‘overwrite existing translations’ from the Reviewers role. I don’t think this is needed for reviewers. Also, you can add as suggestion and go one by one, but I felt the ability to screw up and not realising was just too much.
>
> Putting “upload translations” aside, it is my understanding that at some point, we wanted Reviewers to be able to quickly fix breakage introduced by other translators, hence the “overwrite” permission. I totally trust you to figure out the best trade off between “enabling trusted folks to fix problems” and “the risk that they mess up”. And if folks later complain about this change, we can reconsider and iterate! :)

Sorry I was not clear enough. The power I took out was ONLY related to uploading translations, i.e. ‘overwrite existing translations with the ones you upload’. Reviewers can still go to the string and change it, they are only unable to change it massively through the process of uploading a new .po file. If a component has some strings translated, when reviewers add different strings they are going to be added as suggestions, and they can accept them to change the already translated string.

#6 Updated by intrigeri 2020-04-19 12:01:19

> Sorry I was not clear enough. The power I took out was ONLY related to uploading translations, i.e. ‘overwrite existing translations with the ones you upload’. Reviewers can still go to the string and change it, they are only unable to change it massively through the process of uploading a new .po file. If a component has some strings translated, when reviewers add different strings they are going to be added as suggestions, and they can accept them to change the already translated string.

OK, this looks just perfect to me, then!

Thank you for clarifying :)

#7 Updated by emmapeel 2020-04-24 09:16:56

  • Description updated

make description more clear

#8 Updated by emmapeel 2020-04-24 13:03:33