Feature #17514

Allow reviewers to delete suggestions

Added by emmapeel 2020-03-10 11:06:10 . Updated 2020-04-19 06:19:28 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
Type of work:
Sysadmin
Blueprint:

Starter:
0
Affected tool:
Translation Platform
Deliverable for:

Description

Some suggestions are OK, some you can ‘Accept & edit’, changing the part that is problematic, others are plain wrong.

So, when reviewers are reviewing the suggestions, they should be able to delete the ones that are not good. Otherwise there are many suggestions that are not good and look like pending, but they are not going to be accepted.

In case this is seen as bad, we could make reviewer groups per language


Subtasks


History

#1 Updated by emmapeel 2020-03-10 11:09:27

  • Description updated

#2 Updated by emmapeel 2020-03-11 12:36:26

I would really like to solve this kinda quickly, the Italian translators are waiting for it to clean up their translations.

In the meantime, if there are no answers, I will give this permission to some reviewers individually so they can do a first clean up, but it would be nice to add it to puppet instead

#3 Updated by ignifugo 2020-03-11 16:38:47

emmapeel wrote:
> I would really like to solve this kinda quickly, the Italian translators are waiting for it to clean up their translations.
>
> In the meantime, if there are no answers, I will give this permission to some reviewers individually so they can do a first clean up, but it would be nice to add it to puppet instead

I confirm that is working

#4 Updated by intrigeri 2020-03-16 09:41:42

AFAICT this change would be compatible with our security model, so +1 from me!

#5 Updated by intrigeri 2020-03-28 10:20:58

This proposal got some support and no objection was raised AFAICT.

emma, would you like to implement this for the @Review role (and ditch the per-individual special casing you had to do) in Weblate?

Once that’s done, as a follow-up there’s a trivial update to do on https://tails.boum.org/contribute/design/translation_platform/. I volunteer to do it.

#6 Updated by emmapeel 2020-03-28 10:31:53

I have done it in the weblate admin interface, but I am not sure how to do it in puppet. Will have a look and report back if I don’t manage.

At the moment, reviewers can delete suggestions.

#7 Updated by intrigeri 2020-03-28 10:46:22

  • Status changed from Confirmed to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:tails|cdb4926ba1db2255b2e0bc683560c38c9a21ee0e.

#8 Updated by intrigeri 2020-03-28 10:48:28

> I have done it in the weblate admin interface

Thank you!

> but I am not sure how to do it in puppet. Will have a look and report back if I don’t manage.

I don’t think that’s managed by Puppet yet. Last status update on Bug #17338 is: “we can improve the script incrementally until it can actually configure/enfoce the ACL by itself”. So I guess hefee and zen will notice that they need to update the script accordingly.

#9 Updated by intrigeri 2020-03-28 11:04:34

>> but I am not sure how to do it in puppet. Will have a look and report back if I don’t manage.
>
> I don’t think that’s managed by Puppet yet. Last status update on Bug #17338 is: “we can improve the script incrementally until it can actually configure/enfoce the ACL by itself”. So I guess hefee and zen will notice that they need to update the script accordingly.

Meh, I misunderstood. I think it’s great if you take a look and adjust the script yourself!

#10 Updated by intrigeri 2020-04-19 06:19:28