Feature #17451

Update / clean up remaining aufs-related bits

Added by intrigeri 2020-01-28 09:09:37 . Updated 2020-02-22 14:42:00 .

Status:
Resolved
Priority:
High
Assignee:
Category:
Target version:
Tails_4.5
Start date:
Due date:
% Done:

100%

Feature Branch:
feature/8415-overlayfs+force-all-tests
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

We should git grep -i aufs and either update or clean up each occurrence.

For example, aufs support in the IUK generation code can go away, and IIRC we have some kludges to workaround aufs bugs somewhere.

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by intrigeri 2020-01-28 09:09:55

#2 Updated by intrigeri 2020-02-21 11:08:18

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri

Here’s the list of occurrences:

  • config/chroot_local-hooks/04-change-gids-and-uids: tracked by Feature #17256
  • config/chroot_local-includes/usr/local/lib/initramfs-pre-shutdown-hook: tracked on Bug #15146
  • config/chroot_local-includes/usr/local/lib/tails-unblock-network
  • config/chroot_local-includes/usr/src/iuk/:
    • Updated the test suite locally to exercise overlayfs by default.
    • I’m wary of fully removing support for generating IUKs based on aufs as part of the first iteration of this work, because I’d like to make it easy to switch back to aufs if needed, so I’ve created Bug #17489 to clean this up later
  • -vagrant/provision/assets/build-tails: AIUI that’s a leftover of an older version of our build system, that used aufs for space optimization; we ditched that in Tails 2.4 → removed—
  • wiki/src/contribute/Linux_kernel.mdwn
  • wiki/src/contribute/design.mdwn
  • wiki/src/contribute/design/Unsafe_Browser.mdwn
  • wiki/src/contribute/design/application_isolation.mdwn
  • wiki/src/contribute/design/incremental_upgrades/archive.mdwn: historical info, that’s OK
  • wiki/src/contribute/design/memory_erasure.mdwn: tracked on Bug #15146
  • wiki/src/contribute/release_process.mdwn
  • wiki/src/contribute/release_process/tails-iuk.mdwn: tracked on Bug #17489
  • wiki/src/contribute/roadmap.mdwn

And in puppet-tails.git:

  • modules/tails/manifests/iuk_builder.pp installs aufs-dkms: tracked on Bug #17489

#3 Updated by intrigeri 2020-02-21 14:15:41

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to segfault

#4 Updated by segfault 2020-02-22 13:01:37

intrigeri wrote:
> Here’s the list of occurrences:
>
> * config/chroot_local-includes/usr/local/lib/tails-unblock-network

aufs is still mentioned in two comments. The first one is still valid, but I’m not sure how useful the information “this is a documented possibility with aufs’ noxino mount option” is if we don’t use aufs.

> * wiki/src/contribute/Linux_kernel.mdwn

I see a reference to submodules/aufs4-standalone, which is called aufs-standalone on stable, and is deleted on the feature branch.

#5 Updated by segfault 2020-02-22 13:01:52

  • Status changed from Needs Validation to In Progress
  • Assignee changed from segfault to intrigeri

#6 Updated by intrigeri 2020-02-22 14:26:43

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to segfault

>> * config/chroot_local-includes/usr/local/lib/tails-unblock-network
>
> aufs is still mentioned in two comments. The first one is still valid, but I’m not sure how useful the information “this is a documented possibility with aufs’ noxino mount option” is if we don’t use aufs.

Right, I missed the 2nd one! Apparently overlayfs can have the same problem; now updated.

>> * wiki/src/contribute/Linux_kernel.mdwn
>
> I see a reference to submodules/aufs4-standalone, which is called aufs-standalone on stable, and is deleted on the feature branch.

Where do you see this? I can find it neither with git grep, nor on https://salsa.debian.org/tails-team/tails/blob/feature/8415-overlayfs+force-all-tests/wiki/src/contribute/Linux_kernel.mdwn.

#7 Updated by segfault 2020-02-22 14:42:00

  • Status changed from Needs Validation to Resolved
  • Assignee deleted (segfault)
  • % Done changed from 0 to 100

intrigeri wrote:
> >> * config/chroot_local-includes/usr/local/lib/tails-unblock-network
> >
> > aufs is still mentioned in two comments. The first one is still valid, but I’m not sure how useful the information “this is a documented possibility with aufs’ noxino mount option” is if we don’t use aufs.
>
> Right, I missed the 2nd one! Apparently overlayfs can have the same problem; now updated.

LGTM

> >> * wiki/src/contribute/Linux_kernel.mdwn
> >
> > I see a reference to submodules/aufs4-standalone, which is called aufs-standalone on stable, and is deleted on the feature branch.
>
> Where do you see this? I can find it neither with git grep, nor on https://salsa.debian.org/tails-team/tails/blob/feature/8415-overlayfs+force-all-tests/wiki/src/contribute/Linux_kernel.mdwn.

Oops, that was actually in Linux_kernel.html, so an old build artifact.