Bug #17415

Fix IUK generation in release process

Added by intrigeri 2020-01-09 18:32:47 . Updated 2020-02-10 09:40:28 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_4.3
Start date:
Due date:
% Done:

100%

Feature Branch:
doc/17415-fix-IUK-generation-in-release-process
Type of work:
Contributors documentation
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

(19:26:02) kibi: intrigeri: the loop is still buggy
(19:26:13) kibi: also, it happily ignores failures and continues
(19:26:21) kibi: chown: cannot access '"/home/kibi/work/clients/tails/release/isos/iuks/v2/Tails_amd64_4.0_to_4.2.1.iuk"': No such file or directory
(19:29:54) kibi: I don't plan on fixing shell quoting issues (meaning testing the bugfixes) on my own
(19:30:09) kibi: at least not right now; and I don't think I need you to do it instead, now.
(19:30:35) kibi: maybe file a ticket? I might take a little break while the IUKs are grinding.

Subtasks

History

#1 Updated by intrigeri 2020-01-10 12:46:08

commit:ce42c549ac4a2eb07e20c9ffa49b92e788029d53 and commit:e3025faeee7db76e5210f2ac597857ad60ef78ab should fix this.

#2 Updated by intrigeri 2020-01-10 12:46:57

Plus, we should add a check to verify that we indeed have generated all the IUKs we want.

#3 Updated by intrigeri 2020-01-11 09:40:02

kibi’s fixes break the “Build the Incremental Upgrade Kits locally” code block in my shell environment. Workaround’ed by running it under /bin/sh. This code block is getting awfully complicated and as we can see, shell-config-dependent, so IMO it’s a good candidate to migrate from inline shell snippet to a Python script.

#4 Updated by intrigeri 2020-01-26 12:26:06

  • Status changed from Confirmed to In Progress
  • Feature Branch set to doc/17415-fix-IUK-generation-in-release-process

#5 Updated by intrigeri 2020-01-26 12:46:22

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to anonym

OK, I have something.

anonym, please either review this ahead of the 4.3 release process, or just test it while you’ll go through this step (the plan is still that I’ll be around to help if anything goes wrong).

Note that https://tails.boum.org/contribute/working_together/roles/release_manager/ has new stuff (“The ISO images for […]”) so you cannot skip the whole section under the “business as usual” assumption.

#6 Updated by intrigeri 2020-01-27 08:18:07

I’ll do Feature #17412 on the same branch.

#7 Updated by intrigeri 2020-02-07 17:34:17

@anonym, note that this only lives on a topic branch, which you’ll need to merge if you want to test this as part of the 4.3 release process :)

#8 Updated by anonym 2020-02-10 09:40:28

  • Status changed from Needs Validation to Resolved
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100

Code looks good to me! I’ve merged it, and will do the testing when preparing Tails 4.3. Worst case I revert the merge.