Bug #17403

Donation campaign vs. test suite

Added by CyrilBrulebois 2020-01-07 15:17:09 . Updated 2020-01-07 18:06:43 .

Test suite
Target version:
Start date:
Due date:
% Done:


Feature Branch:
Type of work:

Affected tool:
Deliverable for:


Seen in Jenkins but also locally, while testing 4.2:

  Scenario: The Tor Browser is using the web browser-specific SocksPort # features/tor_stream_isolation.feature:25
    When I monitor the network connections of Tor Browser               # features/step_definitions/tor.rb:280
    And I start the Tor Browser                                         # features/step_definitions/common_steps.rb:368
    And the Tor Browser loads the startup page                          # features/step_definitions/common_steps.rb:391
      try_for() timeout expired (Timeout::Error)
      ./features/support/helpers/misc_helpers.rb:89:in `rescue in try_for'
      ./features/support/helpers/misc_helpers.rb:36:in `try_for'
      ./features/step_definitions/browser.rb:127:in `page_has_loaded_in_the_Tor_Browser'
      ./features/step_definitions/common_steps.rb:402:in `/^the Tor Browser loads the (startup page|Tails homepage|Tails roadmap)$/'
      features/tor_stream_isolation.feature:28:in `And the Tor Browser loads the startup page'
    Then I see that Tor Browser is properly stream isolated             # features/step_definitions/tor.rb:289
      Scenario failed at time 00:09:31

      Screenshot: /home/kibi/TT/run-2020-01-07_15:46:41_+0100-git_4.2_404679d-4cBZ5e/00:09:31_The_Tor_Browser_is_using_the_web_browser-specific_SocksPort.png

      Systemd journal: /home/kibi/TT/run-2020-01-07_15:46:41_+0100-git_4.2_404679d-4cBZ5e/00:09:31_The_Tor_Browser_is_using_the_web_browser-specific_SocksPort.journal

      Video: /home/kibi/TT/run-2020-01-07_15:46:41_+0100-git_4.2_404679d-4cBZ5e/00:09:31_The_Tor_Browser_is_using_the_web_browser-specific_SocksPort.mkv

I’m attaching a screenshot.

I suspect this is due to the donation campaign. The <title> tag in the HTML page indeed has Tails - Dear Tails user, (even in non-English pages, e.g. https://tails.boum.org/home/index.fr.html) which gets refreshed to something else once the page is fully loaded.

I’m not sure why that is not happening when running the test suite. Maybe the test suite needs to be made smarter. Maybe the donation campaign implementation could be improved…

Filing under test suite for now given that’s how I encountered it.

(Also, while absolutely not trusting my memory, I have a vague recollection of that happening last year already?)




#1 Updated by CyrilBrulebois 2020-01-07 16:06:39

The “Dear Tails user,” string also appears untranslated in the body of the French page, for example.

So that seems like a bigger issue than just the test suite.

#2 Updated by sajolida 2020-01-07 16:40:38

See Feature #12156 which was meant to prevent this. Given that we’re now in the 14th week of the donation campaign, I guess that this was not a bit problem until now. This will go away on Sunday, until next year.

#3 Updated by CyrilBrulebois 2020-01-07 18:06:43

Well, a static <title> I can understand. But the static one we have currently is wrong. Plus we’re lacking translations anyway?