Bug #17363
Ensure only pushes to the master branch trigger a website refresh
0%
Description
One recurring pain point in our release process is: being blocked for dozens of minutes, or even 1h, sometimes several times in a row, while pushing branches other than master, because every push triggers a ping of ikiwiki, and if ikiwiki is already doing a costly website refresh, then this ping is blocked until that refresh completes.
We should ping ikiwiki only when the master branch is being pushed, instead of on every push.
The corresponding code is https://git.tails.boum.org/puppet-tails/tree/files/gitolite/hooks/www_website_ping-post-update.hook.
It’s set up as a Git post-update hook.
Subtasks
Related issues
| Related to Tails - Bug #17361: Streamline our release process | Confirmed | ||
|
Related to Tails - |
Resolved |
History
#1 Updated by intrigeri 2019-12-18 11:45:54
- related to Bug #17361: Streamline our release process added
#2 Updated by intrigeri 2019-12-18 12:00:46
- related to
Bug #17307: nginx "504 Gateway Time-out" while refreshing the website at Tails release time added
#3 Updated by intrigeri 2019-12-18 13:29:31
- Status changed from Confirmed to In Progress
#4 Updated by intrigeri 2019-12-18 13:36:34
- Status changed from In Progress to Needs Validation
- Assignee changed from Sysadmins to zen
- Target version set to Tails_4.2
Done via https://git.tails.boum.org/puppet-tails/commit/?id=61f9c386fc82178b9b4fd5073f28d275f2a10a9b.
Note that I first had to do https://git.tails.boum.org/puppet-tails/commit/?id=7e433f8fff60b390a805073b679f736be5cf5869.
I’ve verified that a push to master triggers a refresh, while a push to another branch does not.
Please review :)
#5 Updated by CyrilBrulebois 2020-01-07 18:00:45
- Target version changed from Tails_4.2 to Tails_4.3
#6 Updated by zen 2020-01-20 16:40:08
- Status changed from Needs Validation to Resolved
Looks good, as it’s already in production I’ll mark as resolved.