Feature #17312

Prevent users from closing Tails Upgrader while an upgrade is being applied

Added by sajolida 2019-12-04 12:11:34 . Updated 2020-03-06 07:48:40 .

Status:
Confirmed
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Upgrader
Deliverable for:

Description

The current dialog when the upgrade is being applied has an “OK” button that, when clicked closes the dialog.

The upgrade is still being applied in the background: tails-upgrader is still running and the USB stick is flashing.

We should prevent people from closing this dialog until the upgrade is fully applied.

At this point, Tails is offline and we recommended people to close everything else. People click OK might wonder what should happen next and we won’t display anything else before several minutes. I guess that a lot of people might restart in doubt of what’s happening.

I guess that this is the root cause behind Bug #14754.

Marking as Elevated as it might lead to a broken Tails.


Files

upgrading.png (11893 B) sajolida, 2019-12-04 12:17:07

Subtasks


Related issues

Related to Tails - Feature #14544: Spend software developer time on smallish UX improvements In Progress 2018-08-31
Related to Tails - Bug #16603: Buggy and confusing UI in the "Upgrading the system" dialog Resolved 2019-03-21

History

#1 Updated by sajolida 2019-12-04 12:11:51

  • related to Feature #14544: Spend software developer time on smallish UX improvements added

#2 Updated by sajolida 2019-12-04 12:17:14

See screenshot in attachment.

#3 Updated by intrigeri 2019-12-05 19:53:08

> The current dialog when the upgrade is being applied has an “OK” button that, when clicked closes the dialog.

This part is tracked on Bug #16603. But Bug #16603 does not cover the (much more ambitious) “Prevent users from closing Tails Upgrader” part so I’d rather keep them separate.

#4 Updated by intrigeri 2019-12-05 19:53:19

  • related to Bug #16603: Buggy and confusing UI in the "Upgrading the system" dialog added

#5 Updated by sajolida 2019-12-07 12:53:47

Sorry for not seeing Bug #16603 earlier. I listed all the open tickets affecting “Upgrader” but apparently went through them too fast.

#6 Updated by intrigeri 2020-01-25 12:20:26

intrigeri wrote:
> But Bug #16603 does not cover the (much more ambitious) “Prevent users from closing Tails Upgrader” part

FTR, segfault’s branch for Bug #16603 hides the “OK” button, which is great. But one can still close the dialog by pressing “ESC” (and possibly via the task bar, I did not check this) so we’re not there yet.

Once this change is applied, do you think priority = Elevated is still deserved?

#7 Updated by sajolida 2020-03-05 17:15:14

> Once this change is applied, do you think priority = Elevated is still deserved?

Good news! Probably not but I should check once it’s fixed. I also want
to test again Feature #17313 at some point.

#8 Updated by intrigeri 2020-03-06 07:48:40

>> Once this change is applied, do you think priority = Elevated is still deserved?
>
> Good news! Probably not but I should check once it’s fixed.

To be clear, it’s been fixed in 4.3 so you’ll can test this while upgrading to 4.4 or newer :)