Bug #17132

Don't ship 16-greeter hook dependency

Added by segfault 2019-10-08 10:37:18 . Updated 2019-10-14 13:27:00 .

Status:
Resolved
Priority:
Normal
Assignee:
intrigeri
Category:
Target version:
Tails_4.0
Start date:
Due date:
% Done:

100%

Feature Branch:
bugfix/17132-dont-ship-greeter-hook-dependency
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Today I learned that we have a function that we can use in the hooks to install dependencies and remove them afterwards, so that we don’t ship them in our releases. I remembered that I installed a hook dependency for 16-greeter recently - I think we should use ensure_hook_dependency_is_installed() instead.

The relevant commit it 77ebe7c70c80fc84bbc172369537a1ada04ca8d1.

Subtasks

Related issues

Related to Tails - Bug #17139: Only ship locale definitions that the user can select in the Greeter Confirmed
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by segfault 2019-10-08 10:41:17

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|fb3b3efd1229d7f01df6b1f8e4d30a8c986c9087.

#2 Updated by segfault 2019-10-08 10:41:39

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

#3 Updated by segfault 2019-10-08 10:41:53

#4 Updated by intrigeri 2019-10-09 06:24:36

  • Feature Branch set to bugfix/17132-dont-ship-greeter-hook-dependency

#5 Updated by intrigeri 2019-10-09 06:26:30

  • Assignee set to intrigeri

#6 Updated by intrigeri 2019-10-09 06:41:42

  • Status changed from Needs Validation to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:tails|894d783d485b1b6b6a2d6d234d3462d2f7c3cc0e.

#7 Updated by intrigeri 2019-10-09 06:50:15

  • related to Bug #17139: Only ship locale definitions that the user can select in the Greeter added

#8 Updated by intrigeri 2019-10-11 04:38:50

  • Status changed from Resolved to In Progress
  • Assignee deleted (intrigeri)
  • % Done changed from 100 to 50

Hmm, I’m confused. I think I did check that on this branch, the locales package did not end up in the resulting images. But maybe I’ve been sloppy and forgot that step. Either way, the locales package is included in 4.0~rc1. I’m not sure why apt-get --yes --purge autoremove does not remove it: it could be because locales is Priority: standard, or because APT does not notice that the dependencies of other packages are already satisfied by locales-all — go figure.

Anyway, this package is rather large, so let’s try to remove it again. I think we’ll need to explicitly deinstall it in config/chroot_local-hooks/98-remove_unwanted_packages.

#9 Updated by segfault 2019-10-11 14:03:31

  • Assignee set to segfault

#10 Updated by segfault 2019-10-13 21:26:46

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

#11 Updated by segfault 2019-10-13 21:29:07

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|1dc510eb8be987dabc447eb2ac09ba00ebd0a390.

#12 Updated by intrigeri 2019-10-14 08:23:56

  • Status changed from In Progress to Needs Validation

(I assume reverting to “In Progress” was caused by pushing an extra commit that references this ticket, possibly due to rebasing.)

#13 Updated by intrigeri 2019-10-14 08:31:27

  • Assignee set to intrigeri

#14 Updated by intrigeri 2019-10-14 12:09:30

Code review passes. I’ll check that the Greeter still works before merging.

#15 Updated by intrigeri 2019-10-14 13:27:00

  • Status changed from Needs Validation to Resolved
  • % Done changed from 50 to 100

Applied in changeset commit:tails|82e180bc78ed697645b09648a97bc54cd4f9c3e8.