Bug #17129

rename puppet-tails:update_weblate_git.py → merge_canonical_changes.py

Added by hefee 2019-10-07 15:26:29 . Updated 2020-02-22 15:15:14 .

Status:
Resolved
Priority:
Normal
Assignee:
hefee
Category:
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
https://salsa.debian.org/hefee/puppet-tails:hefee/17129-rename-update_weblate_git
Type of work:
Sysadmin
Blueprint:

Starter:
Affected tool:
Translation Platform
Deliverable for:

Description

The name update_weblate_git.py doesn’t reflect anymore what the script is doing, that’s why a rename makes sense to reflect what the script is doing.

If the script is renamed, also the documentation(Feature #15086) needs to be updated.

Subtasks

Related issues

Related to Tails - Feature #15086: Translation platform: Write design documentation Resolved

History

#1 Updated by hefee 2019-10-07 15:26:58

  • related to Feature #15086: Translation platform: Write design documentation added

#2 Updated by hefee 2020-02-21 09:40:54

  • Status changed from Confirmed to Needs Validation
  • Assignee set to zen
  • Feature Branch set to https://salsa.debian.org/hefee/puppet-tails:hefee/17129-rename-update_weblate_git

As the ticket also needs documentation update, don’t close the ticket, when it is merged in puppet-tails.

#3 Updated by zen 2020-02-22 14:48:35

  • Assignee changed from zen to hefee

I have merged this, but had to fix a wrong renaming (please see 56f547c5f9cc709fab83d82004a7c164f5acb01c and double check my fix) and also removed by hand the following files from the server:

/var/lib/weblate/scripts/update_weblate_git.py
/var/lib/weblate/config/updateWeblateGit.conf

AFAIK, there’s no simple/canonical way to move files with Puppet, and usually you should either maintain the resource and make it ensure => absent or track it by hand as i did now.

I’m leaving this issue open so @hefee can take a look at my fix to confirm it’s ok.

#4 Updated by hefee 2020-02-22 15:15:14

  • Status changed from Needs Validation to Resolved

Seems fine.