Bug #17106

Don't import PO files with no translated string from Transifex

Added by intrigeri 2019-09-30 08:37:56 . Updated 2019-10-03 10:53:13 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Internationalization
Target version:
Tails_4.0
Start date:
Due date:
% Done:

0%

Feature Branch:
bugfix/17106-dont-import-empty-po-files
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

On Bug #16774 we decided we want to import from Transifex:

  • only reviewed translations → this was done for the tails-misc resource on the tails-misc_release branch
  • only PO files with at least one translated+reviewed string → emmapeel tells me she can’t do this on Tor’s side, so we need to filter out these PO files in import-translations

This matters because the code on Feature #16095 will make decisions based on which PO files are present in tails.git:po/, and it assumes that the aforementioned criteria is implemented there.

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed
Blocks Tails - Feature #16095: Curate the list of languages in Tails Greeter Resolved 2018-11-04

History

#1 Updated by intrigeri 2019-09-30 08:38:12

#2 Updated by intrigeri 2019-09-30 08:38:20

  • blocks Feature #16095: Curate the list of languages in Tails Greeter added

#3 Updated by intrigeri 2019-09-30 14:05:41

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|0710b712beb21f3ccf5acaed999815d2697d5bfd.

#4 Updated by intrigeri 2019-09-30 14:07:19

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to segfault
  • Priority changed from Normal to Elevated
  • Feature Branch set to bugfix/17106-dont-import-empty-po-files

Hi @segfault, this review is a little bit more urgent than the other ones I have queued a week ago or so: it blocks Feature #16095 and I’d rather not have to do this by hand when I prepare 4.0~rc1 :)

#5 Updated by intrigeri 2019-10-03 09:24:07

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|df30aca514e0b6e423f1ac1836527971a53e1390.

#6 Updated by segfault 2019-10-03 09:34:23

  • Status changed from In Progress to Fix committed

Oh, rebasing on origin/devel dropped my merge commit.

#7 Updated by segfault 2019-10-03 10:53:13

  • Status changed from Fix committed to Resolved
  • Assignee deleted (segfault)