Bug #17087

Greeter applies setting when user clicks "Cancel" or "Back"

Added by segfault 2019-09-23 14:13:23 . Updated 2020-04-15 06:02:24 .

Status:
Resolved
Priority:
Normal
Assignee:
intrigeri
Category:
Target version:
Tails_4.0
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/39/commits
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Welcome Screen
Deliverable for:

Description

To reproduce:

  1. In the Greeter, open the Additional Settings dialog (by clicking the “+” button)
  2. Choose any additional setting
  3. Choose one of the rows to change the setting
  4. Click “Cancel” or “Back” instead of “Add”

Result:
The setting is applied, even though the user action was “Cancel” or “Back”.

In the case of MAC Address Spoofing and Network Connection, the setting is applied but not added to the list of “Additional Settings” in the Greeter window. In the case of the Administration Password, the setting is added to this list.

Subtasks

Related issues

Related to Tails - Feature #14544: Spend software developer time on smallish UX improvements In Progress 2018-08-31
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed
Blocked by Tails - Feature #16095: Curate the list of languages in Tails Greeter Resolved 2018-11-04

History

#1 Updated by segfault 2019-09-23 14:14:00

  • Description updated

#2 Updated by segfault 2019-09-23 14:14:30

  • Subject changed from Greeter changes setting when user clicks "Cancel" or "Back" to Greeter applies setting when user clicks "Cancel" or "Back"

#3 Updated by segfault 2019-09-23 14:14:41

  • Target version set to Tails_4.0

#4 Updated by sajolida 2019-09-23 20:01:10

  • related to Feature #14544: Spend software developer time on smallish UX improvements added

#5 Updated by segfault 2019-09-25 17:47:52

#6 Updated by segfault 2019-09-25 19:46:41

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|2b6b2775052294e0edd737bbb149a67b784b9697.

#7 Updated by segfault 2019-09-25 19:48:08

  • Status changed from In Progress to Needs Validation
  • Feature Branch set to feature/16095-curate-languages-in-greeter

#8 Updated by segfault 2019-09-25 21:20:27

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|537d40ab516fe2e3b01d33d278fd3699ef03e980.

#9 Updated by segfault 2019-09-28 23:12:18

  • Status changed from In Progress to Needs Validation

#10 Updated by intrigeri 2019-09-29 14:59:49

  • Assignee set to intrigeri

#11 Updated by intrigeri 2019-09-29 15:23:07

Code review passes, will now build & test.

#12 Updated by intrigeri 2019-09-30 07:34:58

  • blocked by Feature #16095: Curate the list of languages in Tails Greeter added

#13 Updated by intrigeri 2019-09-30 07:42:31

  • Status changed from Needs Validation to In Progress
  • Assignee changed from intrigeri to segfault

It works! Please reassign to me once the branch is ready for merging.

#14 Updated by segfault 2019-10-04 14:00:58

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)
  • Feature Branch changed from feature/16095-curate-languages-in-greeter to https://salsa.debian.org/tails-team/tails/merge_requests/39/commits

#15 Updated by intrigeri 2019-10-05 07:12:27

  • Assignee set to intrigeri

#16 Updated by intrigeri 2019-10-05 15:04:43

  • Status changed from Needs Validation to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:tails|53c6c19a4ede83bcc99337a46c70b8dfe7277f42.

#17 Updated by intrigeri 2020-04-15 06:02:24

  • Affected tool changed from Greeter to Welcome Screen