Bug #17058

Translatable unused sentences in Greeter translation

Added by xin 2019-09-15 16:57:28 . Updated 2020-04-15 06:02:23 .

Status:
Resolved
Priority:
Normal
Assignee:
intrigeri
Category:
Internationalization
Target version:
Tails_4.0
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/39/commits
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Welcome Screen
Deliverable for:

Description

In Transifex I see translation of unused sentences about the Greeter (they are in po/*.po in devel and in “Tails Misc - tails.pot” in Transifex):

-Some have the comment “This string will never be displayed in the 1st version of the greeter.” It seems the second version is not under development, so can you make theses sentences untranslatable?

-others strings don’t have this comment but was not used in the Greeter:
“_Windows Camouflage”, “_Time Zone”, “Failed to relock persistent storage.” and “Relock Persistent Storage”. Can you also make them unstranslatable?

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed
Blocked by Tails - Feature #16095: Curate the list of languages in Tails Greeter Resolved 2018-11-04

History

#1 Updated by intrigeri 2019-09-17 11:23:18

#2 Updated by intrigeri 2019-09-17 11:23:38

  • Status changed from New to Confirmed

I think we should drop the unused bits of UI from config/chroot_local-includes/usr/share/tails-greeter/greeter.ui. If we want to be extra nice to ourselves, we can mention the corresponding commit on the tickets that are about (re-)adding these features, to save some time if/when we do so.

#3 Updated by xin 2019-09-19 09:34:25

  • Description updated

I found other unused strings.

#4 Updated by segfault 2019-09-24 23:32:53

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|c4f9ec289e98f9113b01e2a43361623b8636e1bb.

#5 Updated by segfault 2019-09-24 23:38:56

intrigeri wrote:
> I think we should drop the unused bits of UI from config/chroot_local-includes/usr/share/tails-greeter/greeter.ui. If we want to be extra nice to ourselves, we can mention the corresponding commit on the tickets that are about (re-)adding these features, to save some time if/when we do so.

I found Feature #10830 for the camouflage mode and Feature #11657 for the “Take a Tour” feature, but none for the timezone setting.

#6 Updated by segfault 2019-09-24 23:42:43

  • Status changed from In Progress to Needs Validation
  • Feature Branch set to feature/16095-curate-languages-in-greeter

Not sure if it really makes sense that I put all these Greeter related commits on the Feature #16095 branch, but now that I started I feel like I have to go through with it.

#7 Updated by segfault 2019-09-25 00:16:05

  • Status changed from Needs Validation to In Progress
  • Feature Branch changed from feature/16095-curate-languages-in-greeter to bugfix/17058-unused-greeter-ui-elements

There is actually code which uses these UI elements. We should delete this code too. So this not ready for review yet. I removed the commits from the Feature #16094 branch and put them on a separate branch.

#8 Updated by segfault 2019-09-25 08:36:59

  • Status changed from In Progress to Needs Validation

#9 Updated by segfault 2019-09-25 20:05:03

  • Feature Branch changed from bugfix/17058-unused-greeter-ui-elements to feature/16095-curate-languages-in-greeter

I merged bugfix/17058-unused-greeter-ui-elements into feature/16095-curate-languages-in-greeter, because I plan to work some more on the Greeter on the latter branch and are afraid I would create merge conflicts.

#10 Updated by segfault 2019-09-25 21:20:28

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|eac209b177b43f06b6a9d86383b73d4277db144c.

#11 Updated by segfault 2019-09-28 23:10:08

  • Status changed from In Progress to Needs Validation

#12 Updated by segfault 2019-09-28 23:10:17

  • Target version set to Tails_4.0

#13 Updated by intrigeri 2019-09-29 14:59:54

  • Assignee set to intrigeri

#14 Updated by intrigeri 2019-09-29 15:35:52

LGTM, will now build & test.

#15 Updated by intrigeri 2019-09-30 07:34:49

  • blocked by Feature #16095: Curate the list of languages in Tails Greeter added

#16 Updated by intrigeri 2019-09-30 07:41:49

  • Status changed from Needs Validation to In Progress
  • Assignee changed from intrigeri to segfault

We’re done here! Please reassign to me once the branch is ready for merging.

#17 Updated by segfault 2019-10-04 14:01:12

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)
  • Feature Branch changed from feature/16095-curate-languages-in-greeter to https://salsa.debian.org/tails-team/tails/merge_requests/39/commits

#18 Updated by intrigeri 2019-10-05 07:12:26

  • Assignee set to intrigeri

#19 Updated by intrigeri 2019-10-05 15:04:44

  • Status changed from Needs Validation to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:tails|53c6c19a4ede83bcc99337a46c70b8dfe7277f42.

#20 Updated by intrigeri 2020-04-15 06:02:23

  • Affected tool changed from Greeter to Welcome Screen