Tails

#1 Updated by intrigeri 2019-08-01 12:47:06

@hefee, can you easily tell us how expensive this would be to implement?

#2 Updated by intrigeri 2019-08-01 14:39:01

> * If there are several suggestions with the largest number of votes, then pick the newest one.

drebs and I have tried to implement this with https://git-tails.immerda.ch/puppet-tails/commit/?id=afacf5d62f7b112a1070ed472c84ae675c24c3c7 and have prepared a test string with several suggestions (in wiki/src/sandbox.fr.po). Now building the staging website, will report back once we can see the output.

#3 Updated by intrigeri 2019-08-01 15:04:28

intrigeri wrote:
> > * If there are several suggestions with the largest number of votes, then pick the newest one.
>
> drebs and I have tried to implement this with https://git-tails.immerda.ch/puppet-tails/commit/?id=afacf5d62f7b112a1070ed472c84ae675c24c3c7 and have prepared a test string with several suggestions (in wiki/src/sandbox.fr.po). Now building the staging website, will report back once we can see the output.

It worked! :)

So the only remaining thing to evaluate here is “Pick the suggestion with most number of votes” (and only fall back to date comparison to disentangle equality there).

#4 Updated by hefee 2019-08-09 17:55:37

It should be quite simple to implement this. I expect something like 10-15min. It should be something like this. But I havn’t tested it yet. Maybe we need reverse=True, as parameters for sort or replace next() with list()[0] or list()[–1]:

<code class="diff">
--- a/files/weblate/scripts/save-suggestions.py
+++ b/files/weblate/scripts/save-suggestions.py
@@ -64,7 +64,9 @@ for i in range(len_subprojects):
         for translation in subproject.translation_set.all():
             for unit in translation.unit_set.all():
                 if unit.suggestions:
-                    s = list(unit.suggestions)[0]
+                    # Get most voted suggestion
+                    date_sorted = sorted(unit.suggestions, key=lambda i: i.timestamp))
+                    s = next(sorted(date_sorted, key=lambda i: i.get_num_votes()))
                     logger.debug("found suggestion for %s", unit)
                     # weblate/trans/models/translations.py: update_units
                     src = unit.get_source_plurals()[0]
</code>