Feature #16920
Prepare the banner for the donation campaign
0%
Description
Subtasks
History
#1 Updated by sajolida 2019-08-17 16:36:07
- Assignee set to sajolida
#2 Updated by intrigeri 2019-09-12 14:25:24
- Target version changed from Tails_3.17 to Tails_4.0
#3 Updated by sajolida 2019-09-21 00:14:54
- Subject changed from Prepare the donation banner to Prepare the banner for the donation campaign
- Status changed from Confirmed to Needs Validation
- Assignee deleted (
sajolida) - Feature Branch set to web/16920-donation-banner
The same as last year, minus the counter.
#4 Updated by sajolida 2019-09-28 19:05:03
- Assignee deleted (
None)
#5 Updated by Anonymous 2019-10-01 14:56:41
- Status changed from Needs Validation to In Progress
- Assignee set to sajolida
Looks mostly good with some questions from my side.
For the upper banner:
- can we have translations in IT and PT? The second sentence is not translated.
- what is the accounts.fods file? I did not understand
- why did you reenable the JS, that has outdated information and outdated code:
var endOfCampaign = new Date("2019-01-15");The counter is not present anywhere besides in the two files:
fgrep -r counter-number-of-days *
config/chroot_local-includes/usr/share/doc/tails/website/donate-banner.js: var numberOfDays = document.getElementsByClassName('counter-number-of-days');
wiki/src/donate-banner.js: var numberOfDays = document.getElementsByClassName('counter-number-of-days');
for the banner on /home
- “But, not everyone can donate.” → i would delete the comma and not underline the text, as it looks like a link. Maybe have the background of this sentence purple instead? I remember having had the same discussion last year somehow :)
- “When you donate, you are offering to many others who need it, this precious tool that is Tails.” This sentence does not follow the Orwell simplicity writing advice :) Do you think we can make that simpler?
#6 Updated by sajolida 2019-10-02 23:54:27
> - can we have translations in IT and PT? The second sentence is not translated.
I was waiting for your review to call for translations to update various
bits.
> - what is the accounts.fods file? I did not understand
Oops! It’s the file that I used to update the counter last year but this
year we won’t have any. Fixed in 2bc21e55e5.
> - why did you reenable the JS, that has outdated information and outdated code:
Because of mistake :) Fixed in 2bc21e55e5.
> for the banner on /home
>
> - “But, not everyone can donate.” → i would delete the comma
I’m pretty sure that Cody asked for this comma during a review (even
though I’m the author of 9f3516258e).
> and not underline the text, as it looks like a link. Maybe have the background of this sentence purple instead? I remember having had the same discussion last year somehow :)
The exact same code didn’t trigger any discussion last year but
triggered one when working on Feature #14559#21. Anyway, I removed the
underlining as we did in Feature #14559.
> - “When you donate, you are offering to many others who need it, this precious tool that is Tails.” This sentence does not follow the Orwell simplicity writing advice :) Do you think we can make that simpler?
It’s been reviewed by moire, Cody, and translated in several languages
already. Feel free to propose something better if you think that it’s
really worth it to change now.
Other than that, I think that we’re good on this branch.
Thanks for the prompt review!
#7 Updated by sajolida 2019-10-02 23:57:47
- Status changed from In Progress to Fix committed
- Assignee deleted (
sajolida)
Marking as “Fix committed”.
@u might still propose an improvement on “When you donate […]”.
#8 Updated by sajolida 2019-10-07 16:20:12
- Status changed from Fix committed to Resolved
Launched today!