"More information" link in OnionShare settings doesn't open
- Open OnionShare
- Open the Settings dialog
- Click on “More information”
- Nothing happens
#1 Updated by intrigeri 2019-08-11 10:18:07
- Status changed from New to Confirmed
- Assignee set to intrigeri
That’s caused by AppArmor:
audit: AVC apparmor="DENIED" operation="exec" profile="/usr/bin/onionshare-gui" name="/usr/bin/xdg-open" pid=9159 comm="onionshare-gui" requested_mask="x" denied_mask="x" fsuid=1000 ouid=0
Unfortunately, there’s probably no way to allow this without also allowing OnionShare to do tons of other dangerous things. I’ll think about it some more.
@sajolida, do you agree that while it’s annoying, it’s yet another smallish bug, not particularly more important/urgent than others we’ve known for years, and therefore not a blocker for the 4.0 release?
#4 Updated by intrigeri 2019-08-16 15:36:47
> so maybe the way forward would be to change how this is done in the upstream code to be compatible with Tails.
The upstream code already does the same thing as Pidgin or Thunderbird.
To fix this, we need to open up the AppArmor profile a bit. We’ve done so (well, I did that on my volunteer time) in AppArmor upstream for Pidgin and Thunderbird because it felt like opening links was part of their core functionality that the vast majority of users expect to work out-of-the-box. The situation is quite different for a “More information” link in a Settings dialog that I bet most users won’t ever open. I’ll take a look at some point to see if the security risk vs. benefit is worth it. I bet the risk is low and we’ll fix that, but I have to check. Either way, that does not sound like a 4.0 release blocker.
#9 Updated by intrigeri 2019-08-29 16:56:51
- Status changed from Needs Validation to In Progress
I’ve applied these changes to the AppArmor profile in a running Tails (built from devel earlier today) and clicking that link still fails. In the logs, I see a denial about an attempt to execute
/usr/lib/x86_64-linux-gnu/glib-2.0/gio-launch-desktop. Same when clicking the “Help” button. I wonder what’s the difference between my test environment and yours. Maybe we need to steal the rule about
gio-launch-desktop that I see in the evince and thunderbird profiles?