Feature #16901

Only scrub HTML on blueprints

Added by sajolida 2019-07-20 17:00:41 . Updated 2019-07-30 22:22:05 .

Target version:
Start date:
Due date:
% Done:


Feature Branch:
Type of work:

Affected tool:
Deliverable for:


On all the pages of the website that we wrote lately and that needed some special look, we had to disable the htmlscrubber plugin of ikiwiki through the htmlscrubber_skip configuration variable of ikiwiki.

For example:

This is mostly due to the fact that htmlscrubber disallows the use of custom style sheets but also to be able to add some JavaScript.

Custom style sheets are useful to customize specific pages while preventing local.css to go wild.

I’m tired of editing htmlscrubber_skip each time and having to ask our sysadmins to edit it. See Feature #16540 for a painful example of that.

htmlscrubber was initially enabled on all the website because all pages were publicly editable. Now that only blueprints are editable, I propose to only disable htmlscrubber on all the website except blueprints.




#1 Updated by sajolida 2019-07-20 21:11:42

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|79615b7e46c0d7b6318f7a508a001b8951ec3a73.

#2 Updated by sajolida 2019-07-20 21:15:05

Here is a branch.

You can test it with the patch in attachment. Pages that are not scrubbed turn red. Pages that are scrubbed don’t turn red :)

Once the branch has been validated we should ask our sysadmins to apply this change on the production website.

#3 Updated by sajolida 2019-07-21 14:04:45

It gives a 3% improvement on the build time.

#4 Updated by intrigeri 2019-07-30 22:13:18

  • Assignee set to intrigeri

#5 Updated by intrigeri 2019-07-30 22:17:28

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|2c21b0160be0ef89ef3b590abc011713119e0bf6.

#6 Updated by intrigeri 2019-07-30 22:22:05

  • Status changed from Fix committed to Resolved
  • % Done changed from 100 to 0

Merged and applied the same change on our production website. I’ll let you update Feature #16540 accordingly.