Tails

#1 Updated by hefee 2019-07-12 11:35:13

I think these are both commits happend while our scripts are running and our scripts were failing. I think we now hit a race condition, like we expected and why we want to split the repos Bug #16844.

2019-07-11 11:25:07,034 - root(ERROR): Something unexpected happened. Giving up.
Traceback (most recent call last):
  File "/var/lib/weblate/scripts/update_weblate_components.py", line 223, in <module>
    main()
  File "/var/lib/weblate/scripts/update_weblate_components.py", line 199, in main
    uwg.main(repoPath, 'master', None, remoteBranch, pushChanges=True)
  File "/var/lib/weblate/scripts/update_weblate_git.py", line 419, in main
    index = Index(git.IndexFile.from_tree(r, base, local, remote))
  File "/usr/lib/python3/dist-packages/git/index/base.py", line 348, in from_tree
    repo.git.read_tree(*arg_list, **kwargs)
  File "/usr/lib/python3/dist-packages/git/cmd.py", line 424, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/git/cmd.py", line 873, in _call_process
    return self.execute(call, **_kwargs)
  File "/usr/lib/python3/dist-packages/git/cmd.py", line 687, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git read-tree --reset --aggressive --index-output=/var/lib/weblate/repositories/vcs/tails/index/.git/k9vetxnk 72137b2c0c08de8e1dc80578d81135f3e816aa36 master 72137b2c0c08de8e1dc80578d81135f3e816aa36
  stderr: 'fatal: Unable to create '/var/lib/weblate/repositories/vcs/tails/index/.git/index.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.'

#3 Updated by hefee 2019-07-12 11:45:16

The commits are made by Weblate itself and not by our scripts. But the scripts do strange stuff to the working directory, when preparing the merge. IMO Weblate just take the current working directory when committing.

I saw, that we are able to lock the repository, this may be interesting to lock the repository while we are updating the repo.

weblate/trans/vcs.py l.113
self.lock = FileLock(

Our Git hook accepts the push, when both changes are pushed together, as it is a noop together, as we check only the overall diff and not each diff of each commit.