Bug #16858

Branches based on devel FTBFS since webext-ublock-origin 1.19.0 reached sid

Added by intrigeri 2019-07-08 10:15:46 . Updated 2019-09-05 00:03:39 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_3.16
Start date:
Due date:
% Done:

0%

Feature Branch:
bugfix/16858-ftbfs-ublock-1.19+force-all-tests, torbrowser-launcher:bugfix/16858-ftbfs-ublock-1.19
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Subtasks

Related issues

Related to Tails - Bug #16973: Drop CSS hack for uBlock Origin sidebar Rejected

History

#1 Updated by intrigeri 2019-07-08 10:26:08

  • Status changed from Confirmed to In Progress
  • Feature Branch set to bugfix/16858-ftbfs-ublock-1.19+force-all-tests

#2 Updated by intrigeri 2019-07-08 11:31:40

  • Feature Branch changed from bugfix/16858-ftbfs-ublock-1.19+force-all-tests to bugfix/16858-ftbfs-ublock-1.19+force-all-tests, torbrowser-launcher:bugfix/16858-ftbfs-ublock-1.19

#3 Updated by intrigeri 2019-07-08 12:40:04

Passes our manual “test suite” for uBlock:

* Test if _uBlock_ works:
  - The _uBlock_ icon must be visible.
  - Visit a website that normally displays ads, such as
    <https://www.nytimes.com/>. The ads should not be displayed and
    the uBlock icon should display a strictly positive number of
    blocked elements.

Let’s see what Jenkins thinks.

#4 Updated by intrigeri 2019-07-09 10:18:02

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to segfault

https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_bugfix-16858-ftbfs-ublock-1.19-force-all-tests/1/cucumberTestReport/ looks as good as expected, please review & merge:

  • the tails.git branch into “devel”
  • the torbrowser-launcher.git branch into “master” there

Chances are that we need to cherry-pick this commit if we ever bump APT snapshots on the stable branch, which is likely in the next 3 months.

#5 Updated by segfault 2019-07-11 09:16:29

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|9a862f184506d94d7baa62b4b549b9440bbab288.

#6 Updated by segfault 2019-07-11 09:21:33

  • % Done changed from 100 to 0

intrigeri wrote:
> https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_bugfix-16858-ftbfs-ublock-1.19-force-all-tests/1/cucumberTestReport/ looks as good as expected, please review & merge:
>
> * the tails.git branch into “devel”
> * the torbrowser-launcher.git branch into “master” there

Done

#7 Updated by segfault 2019-07-18 09:15:52

  • Assignee deleted (segfault)

#8 Updated by intrigeri 2019-08-08 14:59:26

  • Status changed from Fix committed to In Progress

Applied in changeset commit:tails|5c1a1ca3eec52358e477a8dc9bc2633a952f3f66.

#9 Updated by intrigeri 2019-08-08 15:08:38

  • Status changed from In Progress to Fix committed

#10 Updated by segfault 2019-08-11 21:09:45

  • related to Bug #16973: Drop CSS hack for uBlock Origin sidebar added

#11 Updated by CyrilBrulebois 2019-09-05 00:03:39

  • Status changed from Fix committed to Resolved