Bug #16834

Upgrade Thunderbird to 60.7.2+

Added by intrigeri 2019-06-22 07:45:07 . Updated 2019-07-10 10:32:40 .

Status:
Resolved
Priority:
Elevated
Assignee:
segfault
Category:
Target version:
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/31
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Email Client
Deliverable for:


Subtasks


Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by intrigeri 2019-06-22 07:45:19

#2 Updated by intrigeri 2019-06-22 07:51:48

  • Description updated

#3 Updated by intrigeri 2019-06-22 13:30:34

  • Priority changed from Normal to Elevated

#4 Updated by intrigeri 2019-07-03 14:03:33

  • Assignee set to intrigeri

@segfault, I’m taking this one as a fallback but I’ll wait until Saturday to work on it, hoping you can take it :)

#5 Updated by intrigeri 2019-07-06 09:13:40

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|b430841081e8e292612542d3cdadfab90ce7da6d.

#6 Updated by intrigeri 2019-07-06 11:04:39

  • Feature Branch set to bugfix/16834-thunderbird-60.7.2+force-all-tests

#7 Updated by intrigeri 2019-07-06 11:37:57

Tested manually with an email address whose ISP is not pre-configured in Thunderbird itself (see Bug #16856). features/thunderbird.feature passes locally. My changes may break reproducibility so I’ll check that before sending this for QA, but a first code review could already happen and save us time later.

#8 Updated by intrigeri 2019-07-06 11:42:44

  • Status changed from In Progress to Needs Validation

(So that reproducibility is tested on Jenkins.)

#9 Updated by intrigeri 2019-07-06 14:18:31

  • Assignee changed from intrigeri to segfault

@segfault, there you go :)

#10 Updated by segfault 2019-07-07 11:34:59

  • Status changed from Needs Validation to In Progress
  • Assignee changed from segfault to intrigeri
  • Feature Branch changed from bugfix/16834-thunderbird-60.7.2+force-all-tests to https://salsa.debian.org/tails-team/tails/merge_requests/31

I like the change! Just have a few comments, wrote them on the gitlab MR I created.

#11 Updated by intrigeri 2019-07-07 11:53:22

> I like the change!

:)

> Just have a few comments, wrote them on the gitlab MR I created.

@segfault, thanks!

I’ll try my best but it’s not very likely that I manage to look into that before Monday night, and it’ll be too late for 3.15. So if you think that the state of my branch (including the Thunderbird security update) is a net improvement over not merging it at all, please merge it and I’ll handle your review post-3.15.

#12 Updated by intrigeri 2019-07-07 12:21:46

  • Status changed from In Progress to Needs Validation
  • Assignee changed from intrigeri to segfault

@segfault, I’ve replied on the MR, fixed one issue, and the only remaining discussion is about a possible follow-up step we could take, even further on the path I’ve taken here. It does not look like a blocker for merging, right?

#13 Updated by segfault 2019-07-07 13:26:18

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|8b217f0ba0fb915b15329dbaac4ba36fa01ea4a7.

#14 Updated by CyrilBrulebois 2019-07-10 10:32:40

  • Status changed from Fix committed to Resolved