Bug #16817

Emergency shutdown automated tests on Buster often fail to notice that memory wipe was completed

Added by intrigeri 2019-06-17 15:13:46 . Updated 2019-06-18 10:26:53 .

Status:
Resolved
Priority:
Elevated
Assignee:
intrigeri
Category:
Test suite
Target version:
Tails_4.0
Start date:
Due date:
% Done:

0%

Feature Branch:
test/16817-emergency-shutdown
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

I see lots of “FindFailed: can not find MemoryWipeCompleted.png” while the video shows that the expected message was displayed (so I have a doubt wrt. the image update in commit:56f58e34d2bca109dc2f7d2467d2bc1364732355).

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by intrigeri 2019-06-17 15:14:26

(I won’t file tickets for every Buster test suite problem you surely know about already, but I need to at least track those that block the first beta.)

#2 Updated by intrigeri 2019-06-17 15:14:34

#3 Updated by intrigeri 2019-06-17 15:29:52

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri

And indeed, https://jenkins.tails.boum.org/view/RM/job/test_Tails_ISO_feature-buster/212/artifact/build-artifacts/sikuli_candidates/MemoryWipeCompleted.png looks more like what we have on our 3.x branches. I’m starting to suspect that commit:56f58e34d2bca109dc2f7d2467d2bc1364732355 was only needed due to Bug #16743 and now breaks stuff.

#4 Updated by intrigeri 2019-06-17 15:33:14

  • Feature Branch set to test/16817-emergency-shutdown

#5 Updated by intrigeri 2019-06-17 16:12:17

features/emergency_shutdown.feature passes for me locally on this branch. Let’s see what Jenkins thinks and especially, check that sikuli does not need to do fuzzy matching to find the picture.

#6 Updated by intrigeri 2019-06-18 06:52:20

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (intrigeri)

intrigeri wrote:
> features/emergency_shutdown.feature passes for me locally on this branch. Let’s see what Jenkins thinks

That feature passed twice on https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-16817-emergency-shutdown/.

> and especially, check that sikuli does not need to do fuzzy matching to find the picture.

No MemoryWipeCompleted.png in https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-16817-emergency-shutdown/1/artifact/build-artifacts/sikuli_candidates/ nor https://jenkins.tails.boum.org/view/Tails_ISO/job/test_Tails_ISO_test-16817-emergency-shutdown/2/artifact/build-artifacts/sikuli_candidates/.

So I think my hypothesis above this correct and this branch is the right thing to do.

#7 Updated by hefee 2019-06-18 10:02:50

  • Assignee set to hefee

#8 Updated by hefee 2019-06-18 10:17:41

  • Status changed from Needs Validation to In Progress
  • Assignee changed from hefee to intrigeri

Go ahaed, this sounds logic for me.

#9 Updated by intrigeri 2019-06-18 10:26:10

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|9858dc2e1e8b89162c6f360305d2202be61d6722.

#10 Updated by intrigeri 2019-06-18 10:26:53

  • Status changed from Fix committed to Resolved
  • % Done changed from 100 to 0