Tails

#2 Updated by segfault 2019-06-17 11:03:42

• File tails-screen-locker-no-dim-labels.png added

intrigeri wrote:
> Indeed, there’s something wrong (tested on feature/buster, not in 3.x). I can’t find any other piece of UI that’s affected so I wonder if the GTK bits of config/chroot_local-includes/usr/local/bin/tails-screen-locker have a bug that causes this. @segfault?

I don’t see a bug here. In the tails-screen-locker code, the GTK label style dim-label is applied to the labels, similar to many other labels in GNOME apps (e.g. Files and Disks). If you think that’s an issue, the fix is easy. See attached what the dialog looks like without the dim style.

@sajolida: Do you prefer the style in the screenshot?

#3 Updated by sajolida 2019-06-17 15:45:52

• Assignee set to segfault

After a quick search I couldn’t find guidelines or semantic for “dim-label” in GTK, but according to the meaning of “dim” in English, I guess that these are meant to be use in place where labels are actually meant to be not-so-accessible in colors: deactivated options and such.

So yes, please always use default “non-dim” label whenever we want our labels to be easy to read.

#4 Updated by segfault 2019-06-18 13:00:36

• File Screenshot from 2019-06-18 14-56-58.png added

sajolida wrote:
> After a quick search I couldn’t find guidelines or semantic for “dim-label” in GTK, but according to the meaning of “dim” in English, I guess that these are meant to be use in place where labels are actually meant to be not-so-accessible in colors: deactivated options and such.

Like I wrote above, the style is actually used quite frequently in GNOME apps. Also for description labels. See for example the attached screenshot of a GNOME settings page.

> So yes, please always use default “non-dim” label whenever we want our labels to be easy to read.

I will change it for the screen locker.

#5 Updated by segfault 2019-06-18 13:02:02

• Status changed from Confirmed to In Progress

Applied in changeset commit:tails|6ed8a43355e008a24a7304bbc4eb0432e7cb0567.

#6 Updated by segfault 2019-06-18 13:02:47

• Status changed from In Progress to Needs Validation
• Assignee deleted (segfault)
• Target version set to Tails_3.15
• % Done changed from 0 to 50
• Feature Branch set to bugfix/16802-screen-locker-dim-labels

#7 Updated by hefee 2019-06-19 10:09:19

• Assignee set to hefee

#8 Updated by hefee 2019-06-19 10:10:32

• Status changed from Needs Validation to In Progress
• Assignee changed from hefee to segfault

Code change looks fine -> review passes. As you already attached screenshots, no need to spin up a iso.

You can merge.

#10 Updated by intrigeri 2019-06-22 08:52:30

• Status changed from In Progress to Needs Validation
• Assignee changed from segfault to intrigeri
• Target version changed from Tails_3.15 to Tails_3.14.2

#11 Updated by intrigeri 2019-06-22 08:53:22

• Status changed from Needs Validation to Fix committed
• % Done changed from 50 to 100

Applied in changeset commit:tails|e54e8f786d260c460606de003675543ce1c7f713.

#12 Updated by intrigeri 2019-06-22 08:53:53

• Assignee deleted (intrigeri)

#13 Updated by anonym 2019-06-24 14:24:32

• Status changed from Fix committed to Resolved