Bug #16744

Remove useless pre-generated Pidgin accounts

Added by anonym 2019-05-23 08:14:20 . Updated 2019-09-05 00:03:48 .

Status:
Resolved
Priority:
Normal
Assignee:
intrigeri
Category:
Target version:
Tails_3.16
Start date:
Due date:
% Done:

100%

Feature Branch:
bugfix/16744-remove-useless-pidgin-accounts+force-all-tests
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Instant Messaging
Deliverable for:

Description

Which I guess was missed when we removed I2P?

Related, we still pre-generate an OFTC account as well, which seems useless given we have no presence there any more.

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by anonym 2019-05-23 08:14:46

#2 Updated by anonym 2019-05-23 08:14:56

#3 Updated by anonym 2019-05-23 08:14:58

#4 Updated by intrigeri 2019-05-23 08:24:56

> Which I guess was missed when we removed I2P?

Indeed (XXX_NICK_XXX\127.0.0.1@ did not match the grep we did back then). And even if/when we re-add I2P support, I think this pre-generated account brings little value and won’t need to come back.

> Related, we still pre-generate an OFTC account as well, which seems useless given we have no presence there any more.

I say let’s remove it too and then we can remove quite some code that’s only there due to generating these accounts.

#5 Updated by segfault 2019-07-14 11:08:39

  • Assignee set to segfault
  • Feature Branch set to bugfix/16744-remove-useless-pidgin-accounts

#6 Updated by segfault 2019-07-14 11:08:57

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|6a198e7a112de0aac139929b5ce216e2f9cebb27.

#7 Updated by segfault 2019-07-14 11:12:29

Removed all code I found related to the pre-generated Pidgin accounts. Let’s see if the test suite passes on Jenkins.

Btw, didn’t we also have pre-generated XMPP accounts once? Why don’t we have those anymore?

#8 Updated by segfault 2019-07-14 11:13:21

  • Subject changed from Pidgin still has a pre-generated I2P account to Remove useless pre-generated Pidgin accounts

#9 Updated by intrigeri 2019-07-14 12:46:41

> Let’s see if the test suite passes on Jenkins.

Much of features/pidgin.feature is tagged fragile so I suggest you add the +force-all-tests suffix to the name of the branch.

> Btw, didn’t we also have pre-generated XMPP accounts once?

I don’t think we’ve ever had that. Contrary to IRC, XMPP requires actually registering an account at a provider, which makes this harder.

Back when we switched our chans to XMPP, some folks started working on this problem, and there’s surely info in some tickets here and there, but IIRC that did not go very far.

#10 Updated by segfault 2019-07-14 13:11:43

  • Feature Branch changed from bugfix/16744-remove-useless-pidgin-accounts to bugfix/16744-remove-useless-pidgin-accounts+force-all-tests

intrigeri wrote:
> > Let’s see if the test suite passes on Jenkins.
>
> Much of features/pidgin.feature is tagged fragile so I suggest you add the +force-all-tests suffix to the name of the branch.

OK.

> > Btw, didn’t we also have pre-generated XMPP accounts once?
>
> I don’t think we’ve ever had that. Contrary to IRC, XMPP requires actually registering an account at a provider, which makes this harder.
>
> Back when we switched our chans to XMPP, some folks started working on this problem, and there’s surely info in some tickets here and there, but IIRC that did not go very far.

OK, then I had a wrong memory.

#11 Updated by segfault 2019-07-14 13:11:56

Built and booted locally, accounts are gone and Pidgin runs without errors. Waiting for test results from Jenkins.

#12 Updated by segfault 2019-07-15 23:10:28

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

The failed test scenarios are unrelated to Pidgin (https://jenkins.tails.boum.org/job/test_Tails_ISO_bugfix-16744-remove-useless-pidgin-accounts-force-all-tests/2/cucumberTestReport/).

#13 Updated by intrigeri 2019-07-30 22:31:04

  • Assignee set to intrigeri

#14 Updated by intrigeri 2019-07-30 22:35:31

  • Target version set to Tails_3.16

Code review passes, will now test.

#15 Updated by intrigeri 2019-07-30 23:24:38

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|7324a1ab4cf198d87006ac911a397ad2193c3213.

#16 Updated by CyrilBrulebois 2019-09-05 00:03:48

  • Status changed from Fix committed to Resolved