Bug #16701

"tails-security-check is using the Tails-specific SocksPort" test is broken when there's a live security advisory

Added by intrigeri 2019-05-06 07:08:57 . Updated 2019-05-23 21:19:26 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_3.14
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/20
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Security Check
Deliverable for:

Description

We currently have a live security advisory for Bug #16694, which breaks this test, probably due to the fact tails-security-check is already running. IMO the “I re-run tails-security-check” step should do systemctl --user restart tails-security-check.service, so that:

  1. any already running tails-security-check is killed, which should fix this bug
  2. we test tails-security-check in an environment closer to how it’s run in a real Tails: as we can see on Bug #16603, running this kind of scripts via systemd or without it can yield subtly different behavior

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by intrigeri 2019-05-06 07:47:09

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|c36f0684a85bcf7aca435110211c18709350487e.

#2 Updated by intrigeri 2019-05-06 07:49:35

  • Assignee changed from intrigeri to anonym
  • Target version set to Tails_3.14
  • QA Check set to Ready for QA
  • Feature Branch set to https://salsa.debian.org/tails-team/tails/merge_requests/20

@anonym, can you please review this?

#3 Updated by intrigeri 2019-05-06 07:50:37

#4 Updated by anonym 2019-05-08 12:45:45

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|190b96816f629c440e10e0658a6bda19d00585b4.

#5 Updated by anonym 2019-05-08 12:47:57

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

Merged! Details on Salsa! :)

#6 Updated by CyrilBrulebois 2019-05-23 21:19:26

  • Status changed from Fix committed to Resolved