Bug #16601

Translations don't work in Additional Software

Added by xin 2019-03-21 10:17:06 . Updated 2019-09-05 00:03:22 .

Status:
Resolved
Priority:
Normal
Assignee:
intrigeri
Category:
Internationalization
Target version:
Start date:
2019-03-21
Due date:
% Done:

100%

Feature Branch:
bugfix/16601-fix-translations
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:

Description

In Tails in French, the text is in English in the Additional Software application and in notifications about Additional Software.
All this content is tranlated in po/fr.po. This bug may be present since 3.9 release.

I also test in Spanish, same problem.


Subtasks


History

#1 Updated by xin 2019-03-21 10:18:02

  • Subject changed from Translations doesn't work in Additional Software to Translations don't work in Additional Software

#2 Updated by alant 2019-04-05 18:11:07

  • Status changed from New to In Progress
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16601-fix-translations

#3 Updated by intrigeri 2019-06-02 14:42:59

  • Status changed from In Progress to Needs Validation

#4 Updated by segfault 2019-08-04 20:39:10

  • Assignee changed from alant to segfault

The strings from configuration-window.ui are still not being translated, even though the translations are in the PO file. I had the same issue with unlock-veracrypt-volumes and will implement the same fix, i.e. use intltool_merge_xml on the .ui file.

#5 Updated by segfault 2019-08-04 20:47:40

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|f7f7cdfcd092148b0c91de6185004efc90bb4b56.

#6 Updated by segfault 2019-08-04 20:48:55

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

Code review for Alan’s commit passes, my commit still has to be reviewed.

#7 Updated by segfault 2019-08-04 20:51:27

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|efaa4176db79576c25130adc4bf1c79ab7cb8f74.

#8 Updated by segfault 2019-08-04 21:30:37

  • Assignee set to segfault

This still doesn’t work. I suspect that’s because domain="tails" is missing in the configuration-window.ui. Maybe that was the issue all along and we don’t have to use intltool_merge_xml. Will test that.

#9 Updated by segfault 2019-08-04 22:11:51

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

segfault wrote:
> This still doesn’t work. I suspect that’s because domain="tails" is missing in the configuration-window.ui. Maybe that was the issue all along and we don’t have to use intltool_merge_xml. Will test that.

That was indeed the case.

#10 Updated by segfault 2019-08-04 22:12:34

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|907c65d4e9c54525325a29bc9d827932c3b6895e.

#11 Updated by segfault 2019-08-04 22:12:55

  • Status changed from In Progress to Needs Validation

#12 Updated by intrigeri 2019-08-06 12:16:59

  • Target version set to Tails_3.16

#13 Updated by intrigeri 2019-08-07 11:45:17

  • Assignee set to intrigeri

#14 Updated by intrigeri 2019-08-07 11:49:00

Code review passes, will now test.

#15 Updated by intrigeri 2019-08-08 07:11:29

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|63ef291cf54889b9720194be23d5a770fd631087.

#16 Updated by CyrilBrulebois 2019-09-05 00:03:22

  • Status changed from Fix committed to Resolved