Bug #16566

Additional Software upgrade fails when APT lists are not uptodate at startup

Added by alant 2019-03-16 11:20:18 . Updated 2019-08-30 16:50:40 .

Status:
Confirmed
Priority:
Normal
Assignee:
alant
Category:
Target version:
Start date:
2019-03-16
Due date:
% Done:

100%

Feature Branch:
bugfix/16566-asp-dl-failure-case-C-with-notification
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
319

Description

case C: a new Tails release including new apt lists is installed. Then the right version of the packages are not in the cache. If user is not connected to the Internet/Tor is not ready when the Gnome session is ready, then tails-additional-software-install.service fails. As a consequence, tails-additional-software-update.path is never run and the problem is not solved until the user starts a session when already connected to Tor (= cable + fast connection).

Subtasks

Related issues

Related to Tails - Bug #16567: Additional Software should upgrade packages after APT lists update Confirmed 2019-03-16

History

#1 Updated by intrigeri 2019-03-16 16:01:28

  • Feature Branch changed from bugfix/15957-asp-dl-failure-case-C to bugfix/16566-asp-dl-failure-case-C

#2 Updated by intrigeri 2019-03-16 16:03:54

Code review passes. It looks like we’ll have CI results in ~1h. If I see no regression there I’ll happily merge.

#3 Updated by intrigeri 2019-03-16 16:50:05

intrigeri wrote:
> It looks like we’ll have CI results in ~1h.

The 1st run had a bit too many failures on non-fragile scenarios for my taste, so I triggered another one. Will come back to it tomorrow.

#4 Updated by alant 2019-03-16 17:03:33

Also I thought that with only this fix (and not the fix for cases A and B) there are more chances that errors will be fixed by the update/upgrade when going online. So I suggest we change the installation error notifications from:

The installation of your additional software failed

to:

The installation of your additional software failed. This may be solved by connecting to Internet.

I can proposed a branch bugfix/16566-asp-dl-failure-case-C-with-notification for that but I’m worried it breaks the test suite.

#5 Updated by alant 2019-03-16 17:18:26

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|15240dd66e9e7b5782d49db3ab2f4531bce04d59.

#6 Updated by intrigeri 2019-03-16 17:55:37

> Also I thought that with only this fix (and not the fix for cases A and B) there are more chances that errors will be fixed by the update/upgrade when going online. So I suggest we change the installation error message from: […] to: […]

I think it’s too late in this cycle to change strings and have them go through sajolida ⇒ please file a dedicated ticket about it if you think it’s worth it (I did not think about it yet; if you want my opinion, I could do that :)

> I can propose a branch for that but I’m worried it breaks the test suite.

No worries: if it does, it’ll be easy to spot and to fix. I might be stating the obvious, but the test suite’s job is to validate the implementation, not to force it to remain as-is.

#7 Updated by intrigeri 2019-03-17 08:24:50

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|04ed66e1c0f12a5b46156162af0685ce80b9250a.

#8 Updated by intrigeri 2019-03-17 08:27:06

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass
  • Deliverable for set to 319

Merged! I have good hopes this will fix the most important part of Bug #15957 in practice :)

#9 Updated by alant 2019-03-17 18:56:41

  • Status changed from Fix committed to Confirmed
  • Target version changed from Tails_3.13 to Tails_3.14
  • QA Check changed from Pass to Ready for QA
  • Feature Branch changed from bugfix/16566-asp-dl-failure-case-C to bugfix/16566-asp-dl-failure-case-C-with-notification

I changed the branch for the one adding “This may be solved by connecting to Internet.” on the install failure notification. This is ready for 3.14.

#10 Updated by intrigeri 2019-03-18 07:24:17

  • Assignee set to alant
  • QA Check changed from Ready for QA to Info Needed

Please:

  1. Sum up for sajolida in which situation the modified string will appear and what’s the proposed string change (I know all this can be found by reading the full history of this ticket + some of its parent ticket + perhaps some of the blueprint but I’m pretty sure sajolida would rather answer a simple question spelled out in one single Redmine comment :)
  2. Reassign to sajolida as “Info Needed”.

Thanks in advance!

#11 Updated by alant 2019-04-02 10:31:27

  • Assignee changed from alant to sajolida

> # Sum up for sajolida in which situation the modified string will appear and what’s the proposed string change

When ASP install at startup fails, the string was:

“The installation of your additional software failed”

Every new Tails release, the install fails and this is solved by connecting to Internet. The proposed string is:

“The installation of your additional software failed This may be solved by connecting to Internet.”

#12 Updated by sajolida 2019-04-17 17:57:43

  • Assignee changed from sajolida to alant
  • QA Check changed from Info Needed to Dev Needed

It’s good! (except it’s “*the Internet”).

This one is a bit more polite and shorter:

“The installation of your additional software failed. Please try to connect to the Internet.”

#13 Updated by Anonymous 2019-04-22 10:50:52

  • related to Bug #16567: Additional Software should upgrade packages after APT lists update added

#14 Updated by CyrilBrulebois 2019-05-23 21:23:28

  • Target version changed from Tails_3.14 to Tails_3.15

#15 Updated by CyrilBrulebois 2019-07-10 10:34:08

  • Target version changed from Tails_3.15 to Tails_3.16

#16 Updated by intrigeri 2019-08-30 16:50:41

  • Target version deleted (Tails_3.16)

Hi!

We’ve set up an automated process to ask our fellow contributors to update some tickets of theirs, in order to:

  • better reflect your plans;
  • bring down your amount of work-in-progress to a sustainable level;
  • encourage team work and increase the chances that someone finishes the work;
  • avoid a human doing ticket triaging and asking you the same questions on each such ticket.

In particular, this process identifies:

  • Stalled work-in-progress
  • Reviews waiting for a long time

However, in the current state of things, this process is not able to notice those tickets when their Target version has been repeatedly postponed by our Release Managers. Therefore, the ticket triaging team decided on Feature #16545 to remove the Target version whenever in such cases, when it does not feel realistic. This is what I’m doing on this ticket.

You now have a few options, such as:

  • Deassign yourself. That’s fine. If it really matters, someone else, possibly you, may pick it up later. Then, if this ticket is relevant for a Tails team, bring it to their attention; else, forget it and take care of yourself :)
  • If you think you can realistically come back to it and finish the work in the next 6 months, say so on this ticket, for example by setting a suitable “Target version”. This will communicate your plans to the rest of the project and ensure the task pops up on your radar at a suitable time. Of course, you can still realize later that it is not going to work as planned, and revisit today’s choice.

Cheers!