Tails

#1 Updated by sajolida 2019-02-24 13:03:48

• File 0001-Allow-using-custom-CSS-for-personas.patch added
• Assignee changed from sajolida to groente
• Feature Branch set to contrib/15714-publish-personas

I have a branch now.

I need our beloved sysadmins to allow using custom CSS on these pages (I used Bootstrap to make them look nice efficiently).

I’m putting in attachment a patch for puppet-tails.git. Please tell me once it’s applied and I’ll merged my branch.

#2 Updated by sajolida 2019-02-24 13:05:01

• Feature Branch changed from contrib/15714-publish-personas to contrib/16483-publish-personas

#3 Updated by intrigeri 2019-02-24 13:13:05

• Assignee changed from groente to bertagaz

(Assigning to the sysadmin currently on duty.)

#5 Updated by bertagaz 2019-02-24 16:10:05

• Status changed from Confirmed to In Progress
• Assignee changed from bertagaz to sajolida

sajolida wrote:
> I need our beloved sysadmins to allow using custom CSS on these pages (I used Bootstrap to make them look nice efficiently).
>
> I’m putting in attachment a patch for puppet-tails.git. Please tell me once it’s applied and I’ll merged my branch.

Deployed!

#6 Updated by sajolida 2019-02-25 06:15:19

• Assignee changed from sajolida to bertagaz

Thanks for doing this so promptly!

I merged my branch but the additional CSS were removed from the resulting page.
On my local builts the same changes my ikiwiki.setup works to have the extra CSS.
Could it be that the changes were not applied correctly?

Or that the website needs to be rebuilt for them to be taken into account (though on my local build, updating the personas page was enough to have them include the additional CSS)?

#7 Updated by bertagaz 2019-02-25 12:23:57

• Assignee changed from bertagaz to sajolida

sajolida wrote:
> Thanks for doing this so promptly!
>
> I merged my branch but the additional CSS were removed from the resulting page.
> On my local builts the same changes my ikiwiki.setup works to have the extra CSS.
> Could it be that the changes were not applied correctly?

I just checked and the changes were correctly deployed.

> Or that the website needs to be rebuilt for them to be taken into account (though on my local build, updating the personas page was enough to have them include the additional CSS)?

I pushed a tiny commit on that page, and it has been rebuilt, but indeed the CSS is not included in the page.

I’ve greped to see how the meta stylesheet was used elsewhere and in the wiki/src/donate.html page the quotes are escaped, but not in the personas page, so maybe that’s why?

#8 Updated by sajolida 2019-02-26 07:47:50

• Assignee changed from sajolida to bertagaz

> I’ve greped to see how the meta stylesheet was used elsewhere and in the wiki/src/donate.html page the quotes are escaped, but not in the personas page, so maybe that’s why?
What do you mean by that?

In donate.html we have:

[[!meta stylesheet="bootstrap.min" rel="stylesheet" title=""]]
[[!meta stylesheet="personas" rel="stylesheet" title=""]]

[[!meta stylesheet="bootstrap.min" rel="stylesheet" title=""]]
[[!meta stylesheet="donate" rel="stylesheet" title=""]]

And no different apart from s/donate/personas/.

I now tried to use a full path in 6358b6ba73 but it didn’t change anything either.

What else can I try on my side?

#10 Updated by bertagaz 2019-02-26 12:44:02

• Assignee changed from bertagaz to sajolida

sajolida wrote:
> In donate.html we have:
>
> […]
>
> And no different apart from s/donate/personas/.

Oops sorry, I’ve read the grep result too fast. Quoting was indeed only in the po files. :)

intrigeri wrote:
> I suspect one needs to update the ikiwiki wrappers with the —wrappers option.

Good catch, I’ve run a rebuild with this option, and indeed the page looks better now.

#11 Updated by sajolida 2019-02-27 08:20:35

• Status changed from In Progress to Resolved
• Assignee deleted (sajolida)

Yeah! Well done!

#12 Updated by intrigeri 2019-03-07 08:28:54

• related to Bug #16542: Refresh ikiwiki wrappers when ikiwiki.setup.erb is updated added