Feature #16433

Add tails-additional-software-add

Added by sajolida 2019-02-07 10:55:50 . Updated 2019-02-11 13:51:30 .

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.13
Start date:
2019-02-07
Due date:
% Done:

0%

Feature Branch:
feature/16433-tails-additional-software-add
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:

Description

Currently we have a command line utility to remove a package from the list of Additional Software:

https://git.tails.boum.org/tails/tree/config/chroot_local-includes/usr/local/sbin/tails-additional-software-remove

Having an equivalent to add a package to the list would allow applications, like Whiskers, to bypass the notifications when installing packages. See https://gitlab.com/scif/whiskers/issues/72.

Subtasks

History

#1 Updated by sajolida 2019-02-07 11:08:15

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|9729e934f808361784af145f4e226b49eceb79f1.

#2 Updated by sajolida 2019-02-07 11:10:30

  • Status changed from In Progress to Confirmed
  • Assignee deleted (sajolida)
  • Target version set to Tails_3.13
  • QA Check set to Ready for QA
  • Feature Branch set to feature/16433-tails-additional-software-add

Here is a branch.

I tested the script locally in my Tails but I didn’t test it in a branch built on Jenkins.

I’ll let the RM for 3.13 decide if this fits in a minor release.

#3 Updated by sajolida 2019-02-07 11:10:55

  • Status changed from Confirmed to In Progress

#4 Updated by intrigeri 2019-02-08 11:54:03

  • Assignee set to sajolida
  • QA Check changed from Ready for QA to Info Needed

I’ve read the corresponding Whiskers ticket and I must say I have problems with the workaround this new script is meant to make easier to implement. Bypassing the Additional Software dpkg hooks this way will probably work fine right now, but it relies on internal implementation details that may change at any time: for example, these dpkg hooks could need to do extra work some day, and then the workaround will break. I’d rather not be in the position when I have to choose between telling the Whiskers folks “well, too bad, you relied on internal implementation details, now you get to keep the pieces” or treating these internal implementation details as public API that we are not allowed to break.

So I’m afraid a real solution (i.e. somehow allow bypassing the notification only) is needed.

Should this ticket be related to Feature #15873 in some way?

> I’ll let the RM for 3.13 decide if this fits in a minor release.

Chances are that 3.13 is a major release.

#5 Updated by intrigeri 2019-02-08 12:17:55

> So I’m afraid a real solution (i.e. somehow allow bypassing the notification only) is needed.

Alternatively, if the Whiskers folks are fine with a hack that may break at any point in the future, I think it’s OK to ship this additional script, but to decrease the chances someone else discovers, starts to rely on it, and is unhappy when we break it:

  1. Don’t ship it in the $PATH: rather put it in /usr/local/lib/.
  2. Add a comment in the script to explain its not supported.

#6 Updated by sajolida 2019-02-11 13:51:30

  • Status changed from In Progress to Rejected
  • Assignee deleted (sajolida)
  • QA Check deleted (Info Needed)

If this has to be a complicated discussion, then I prefer not to bother…