Feature #16357

Deal with Torbutton being integrated into Tor Browser

Added by intrigeri 2019-01-14 08:09:19 . Updated 2019-09-14 11:14:42 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
2019-01-14
Due date:
% Done:

100%

Feature Branch:
Type of work:
Research
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

Upstream ticket: https://trac.torproject.org/projects/tor/ticket/10760

If upstream manages to add a hidden pref to disable it, we should be good. Otherwise, our Unsafe Browser is in trouble.

This change should land in Tor Browser 9.0a1, which should get out end of March/begin of April.


Subtasks


Related issues

Related to Tails - Bug #17039: Unsafe Browser does not start (segfault) with Tor Browser 9 Resolved
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by intrigeri 2019-01-14 08:09:38

#2 Updated by intrigeri 2019-01-14 08:12:04

  • Description updated
  • Target version changed from Tails_3.17 to Tails_3.15

We really have to do this for 3.17 but according to upstream, we could start working on this as early as April. The earlier we try it out and identify issues, the better.

#3 Updated by intrigeri 2019-01-14 08:12:14

#4 Updated by intrigeri 2019-03-20 14:43:48

  • blocked by deleted (Feature #16210: Core work 2019Q3: Foundations Team)

#5 Updated by intrigeri 2019-04-05 13:23:46

We should coordinate with the Tor Browser team during the 3.15 dev cycle.

#6 Updated by intrigeri 2019-07-05 09:27:22

  • Target version changed from Tails_3.15 to Tails_3.16

intrigeri wrote:
> We should coordinate with the Tor Browser team during the 3.15 dev cycle.

I see that anonym did that (https://trac.torproject.org/projects/tor/ticket/10760#comment:44 and https://trac.torproject.org/projects/tor/ticket/10760#comment:45).
Let’s come back to it once the corresponding branch is merged upstream.

#7 Updated by intrigeri 2019-08-30 16:10:21

  • Priority changed from Normal to Elevated
  • Target version changed from Tails_3.16 to Tails_3.17

intrigeri wrote:
> Let’s come back to it once the corresponding branch is merged upstream.

https://trac.torproject.org/projects/tor/ticket/10760 was merged into their master branch (although there are still a few child tickets open). anonym explained there how to test the code. Let’s do this ASAP during the 3.17 cycle!

#8 Updated by intrigeri 2019-09-09 10:30:17

  • Type of work changed from Communicate to Research

At first glance, Torbutton works just fine in Tor Browser; I’ve tested the circuit view and the new circuit feature.

But the Unsafe Browser segfaults on startup. I don’t know if that’s related or an entirely different problem.

#9 Updated by intrigeri 2019-09-09 19:02:10

  • related to Bug #17038: Update test suite for Tor Browser 9's Tor Launcher added

#10 Updated by intrigeri 2019-09-09 19:02:18

  • related to Bug #17039: Unsafe Browser does not start (segfault) with Tor Browser 9 added

#11 Updated by intrigeri 2019-09-12 14:25:26

  • Target version changed from Tails_3.17 to Tails_4.0

#12 Updated by intrigeri 2019-09-12 15:48:52

  • related to deleted (Bug #17038: Update test suite for Tor Browser 9's Tor Launcher)

#13 Updated by intrigeri 2019-09-14 09:57:08

The Unsafe Browser has Torbutton enabled, which overrides the proxy settings we have in config/chroot_local-includes/usr/local/lib/tails-shell-library/chroot-browser.sh, which breaks access to the web. I’ll push a fix.

#14 Updated by intrigeri 2019-09-14 10:26:50

#15 Updated by intrigeri 2019-09-14 10:28:08

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri

#16 Updated by intrigeri 2019-09-14 11:11:57

  • Status changed from In Progress to Resolved

Web access is fixed. If there are other issues wrt. the Unsafe Browser, let’s track them on Feature #17055 and its other children.

#17 Updated by intrigeri 2019-09-14 11:14:43

  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 100