Feature #16339

Adjust download counter to ISO vs IMG

Added by sajolida 2019-01-10 12:48:40 . Updated 2019-01-15 19:19:26 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.12
Start date:
2019-01-10
Due date:
% Done:

0%

Feature Branch:
bugfix/16339-counter-vs-img
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
316

Description

Subtasks

History

#1 Updated by sajolida 2019-01-10 15:55:11

  • Tracker changed from Bug to Feature
  • Subject changed from Download counter doesn't handle ISO vs IMG to Adjust download counter to ISO vs IMG
  • Description updated
  • Assignee changed from sajolida to lamby
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16339-counter-vs-img

Chris: Would you be able to review this small branch to fix the download counter on the branch that integrates USB images?

We worked on the counter in parallel of the adaptations of the download page for the USB images and I clearly broke it in a buggy merge conflict.

Then tell me how much time you spent on this.

#2 Updated by sajolida 2019-01-10 15:55:31

The branch is based on feature/15292-usb-image.

#3 Updated by Anonymous 2019-01-10 16:56:50

@sajolida: when Chris is done with the review, could you please also check how this might affect the verification-extension? There is a patch in the extension for testing locally that is related to the code of the counter in download.js (I did not look at your branch, just at the title of this ticket and inferred that there might be a link.)

#4 Updated by lamby 2019-01-11 18:44:35

  • Assignee changed from lamby to sajolida
  • QA Check changed from Ready for QA to Pass

LGTM. Methodology was:

  • Checked out bugfix/16339-counter-vs-img
  • Built the website
  • Served it locally via cd config/chroot_local-includes/usr/share/doc/tails/website && python -m SimpleHTTPServer to ensure HTTP and not file://
  • Navigate to http://127.0.0.1:8000/install/download.en.html
  • Note the “Download… USB” copy. ie. I have the right branch/build.
  • Check network console for baseline.
  • Check JS console - no errors
  • Click download
  • New window opens pointing to https://mirrors.edge.kernel.org/tails/stable/tails-amd64-3.8/tails-amd64-3.8.img (which 404s, FYI!)
  • See that we do a counter ping both in network console and SimpleHTTPServer
  • Click “I already..”
  • Note another counter ping in both network console and SimpleHTTPServer

(I spent 30 minutes on this; testing JS is click-intensive..)

#5 Updated by sajolida 2019-01-15 17:14:06

> LGTM

Cool! So I merged it into feature/15292-usb-image (and deleted
bugfix/16339-counter-vs-img from tails.git).

> * Served it locally via cd config/chroot_local-includes/usr/share/doc/tails/website && python -m SimpleHTTPServer to ensure HTTP and not file://

Wow, I didn’t know that but it’s really cool! :)

> * New window opens pointing to https://mirrors.edge.kernel.org/tails/stable/tails-amd64-3.8/tails-amd64-3.8.img (which 404s, FYI!)

We’re not serving USB images yet on the mirrors.

> (I spent 30 minutes on this; testing JS is click-intensive..)

I wouldn’t have been faster…

#6 Updated by sajolida 2019-01-15 19:18:25

> @sajolida: when Chris is done with the review, could you please also check how this might affect the verification-extension?

Thanks for chiming in! The patch
verification-extension.git:tails.git-0001-Make-Tails-Verification-work-on-a-local-build-of-the.patch
stills applies fine on the branch feature/15292-usb-image. So we’re good!

#7 Updated by sajolida 2019-01-15 19:19:26

  • Status changed from Confirmed to Resolved
  • Assignee deleted (sajolida)
  • QA Check deleted (Pass)