Bug #16335

Gobby 0.5→0.6 changes in buster: test suite update needed

Added by CyrilBrulebois 2019-01-10 02:51:39 . Updated 2019-04-03 06:08:41 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2019-01-10
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

With the feature/buster branch, gobby gets bumped from 0.5.0-8.1 to 0.6.0~20170204~e5c2d1-3, and the case of one menu item changes a little; ditto for the window it leads to.

This leads to this failure in features/tor_stream_isolation.feature:

    And I connect Gobby to "gobby.debian.org"                                        # features/step_definitions/tor.rb:326
      The Dogtail script raised: SearchError: descendent of [application | gobby-0.5]: "Connect to Server..." menuitem (RuntimeError)
      ./features/support/helpers/dogtail.rb:83:in `run'
      ./features/support/helpers/dogtail.rb:225:in `initialize'
      ./features/support/helpers/dogtail.rb:205:in `new'
      ./features/support/helpers/dogtail.rb:205:in `block (2 levels) in <class:Application>'
      ./features/step_definitions/tor.rb:335:in `/^I connect Gobby to "([^"]+)"$/'
      features/tor_stream_isolation.feature:62:in `And I connect Gobby to "gobby.debian.org"'

Also, it seems there’s an extraneous Ctrl-T, which I could get rid of without triggering any issues.

Two patches attached which fix the test failure. Will push with a reference to this ticket unless there’s something I overlooked.


Files


Subtasks


History

#1 Updated by intrigeri 2019-01-10 07:23:27

  • Status changed from New to In Progress
  • Assignee changed from intrigeri to CyrilBrulebois
  • Parent task set to Bug #16281

Sounds good.

#2 Updated by intrigeri 2019-04-02 14:45:05

  • QA Check set to Ready for QA
  • Type of work changed from Test to Code

#3 Updated by intrigeri 2019-04-03 06:08:41

  • Status changed from In Progress to Resolved
  • Assignee deleted (CyrilBrulebois)
  • QA Check deleted (Ready for QA)

My understanding is that this was fixed. Let’s reopen if there’s something more to do here.