Feature #16334

Add feedback when opening VeraCrypt Mounter

Added by sajolida 2019-01-09 17:30:34 . Updated 2019-03-20 14:27:34 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2019-01-09
Due date:
% Done:

100%

Feature Branch:
feature/16334-feedback-when-opening-veracrypt
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

See Bug #15738.


Files


Subtasks


Related issues

Related to Tails - Bug #15738: Test feedback when opening applications from the Applications menu Resolved 2018-07-17
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by sajolida 2019-01-09 17:34:13

Here is a patch.

#2 Updated by intrigeri 2019-01-09 17:40:33

  • Assignee set to segfault

Hi segfault! Do you want to take this one? Optimistically assigning Bug #16333 to you as well since it is similar (happy to do the release + package update work myself once the code review & testing passes on your side).

#3 Updated by intrigeri 2019-01-09 17:40:38

  • related to Bug #15738: Test feedback when opening applications from the Applications menu added

#4 Updated by segfault 2019-01-10 12:08:54

  • Assignee changed from segfault to sajolida
  • QA Check changed from Ready for QA to Dev Needed

intrigeri wrote:
> Hi segfault! Do you want to take this one?

Yes.

> Optimistically assigning Bug #16333 to you as well since it is similar

OK.

> Here is a patch.

It doesn’t seem to work or I don’t understand what it’s supposed to do. I tested it by adding the two lines to the desktop launcher in Tails (which is called unlock-veracrypt-volumes and not veracrypt-mounter) and then starting the app. I expected the mouse cursor to spin until the window is shown, but the cursor didn’t change. I see a spinner in the top bar but that is also present without the two lines. I made sure that when I start the app it does indeed use the modified desktop launcher (tested by changing the Exec line).

#5 Updated by sajolida 2019-01-12 17:38:09

> I don’t understand what it’s supposed to do.

Yes, It’s supposed to change the mouse cursor into a spinner right after
choosing to start the app. Since VeraCrypt Mounter opens super fast,
it’s only visible for less than a second on my machine (but I guess it
could take longer in worse conditions).

> I made sure that when I start the app it does indeed use the modified desktop launcher (tested by changing the Exec line).

Did you also restart GNOME Shell? I need to do this for my changes to be
applied on Tails:

Alt + F2 + typing “r” or “gnome-shell —replace”

#6 Updated by sajolida 2019-01-12 17:42:49

  • Assignee changed from sajolida to segfault
  • QA Check changed from Dev Needed to Ready for QA

#7 Updated by segfault 2019-01-18 10:30:00

  • Feature Branch set to feature/16334-feedback-when-opening-veracrypt

> Did you also restart GNOME Shell? I need to do this for my changes to be
> applied on Tails:
>
> Alt + F2 + typing “r” or “gnome-shell —replace”

This worked, thanks for the hint.

I applied the patch and am now building the branch to test it. Maybe this can still make it into 3.12.

#8 Updated by segfault 2019-01-18 10:30:40

> I applied the patch

I replaced veracrypt-mounter with unlock-veracrypt-volumes in the patch.

#9 Updated by sajolida 2019-01-18 12:12:38

> I replaced veracrypt-mounter with unlock-veracrypt-volumes in the patch.

Sure :)

#10 Updated by segfault 2019-01-20 18:35:18

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|0088f154479cebb2ddf85b8b21d156abb2f47973.

#11 Updated by segfault 2019-01-20 18:37:30

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|f2cc0f1f0b8cfce3aeb0e4ff90ba12bd5fd62818.

#12 Updated by segfault 2019-01-20 18:38:53

  • Target version changed from Tails_3.12 to Tails_3.13
  • % Done changed from 100 to 0
  • QA Check changed from Ready for QA to Pass

Built the branch and tested it. Merged into devel.

#13 Updated by intrigeri 2019-02-11 08:59:50

  • Status changed from Fix committed to In Progress
  • Assignee changed from segfault to intrigeri
  • % Done changed from 0 to 90

3.13 won’t be built from devel and there’s a chance we have no major release for a long while, so I’ll consider cherry-picking this into stable later this week.

#14 Updated by intrigeri 2019-02-19 18:23:52

  • Status changed from In Progress to Fix committed
  • % Done changed from 90 to 100

Applied in changeset commit:tails|7235487c3e89c2535498ba3e1ea3d213e2cfcdb2.

#15 Updated by intrigeri 2019-02-19 18:24:41

  • Assignee deleted (intrigeri)

Merged into stable as well, so this gets released sooner rather than later. Thanks!

#16 Updated by CyrilBrulebois 2019-03-20 14:27:34

  • Status changed from Fix committed to Resolved

#17 Updated by intrigeri 2019-04-25 08:19:56