Feature #16300
Please include profiling output in diffoscope checks
100%
Description
Please include profiling output in diffoscope checks to help upstream. Also attached, but:
From e38d56bd52ca9b5df0c1b55aa2c0cdee82b5456e Mon Sep 17 00:00:00 2001
From: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat, 5 Jan 2019 21:46:34 +0100
Subject: [PATCH] Include profiling information in diffoscope output.
---
files/jenkins/slaves/isobuilders/compare_artifacts | 1 +
1 file changed, 1 insertion(+)
diff --git a/files/jenkins/slaves/isobuilders/compare_artifacts b/files/jenkins/slaves/isobuilders/compare_artifacts
index cdfe3020..7f2de597 100644
--- a/files/jenkins/slaves/isobuilders/compare_artifacts
+++ b/files/jenkins/slaves/isobuilders/compare_artifacts
@@ -29,6 +29,7 @@ dothediffo()
--max-report-size 262144000 \
--max-diff-block-lines 10000 \
--max-diff-input-lines 10000000 \
+ --profile=- \
$IMAGEFILES; then
sudo rm $IMAGEFILES
else
--
2.20.1
Files
Subtasks
History
#1 Updated by intrigeri 2019-01-06 07:13:25
- Status changed from New to In Progress
- Target version set to Tails_3.12
- QA Check set to Ready for QA
#2 Updated by intrigeri 2019-01-06 07:18:44
- % Done changed from 0 to 50
Thanks! git am
’ed and deployed on all affected systems. Will check resulting Jenkins output before closing as resolved.
#3 Updated by intrigeri 2019-01-06 07:19:47
https://jenkins.tails.boum.org/job/reproducibly_build_Tails_ISO_hefee-feature-15297-keepassxc/2/console should be the first build to benefit from this change.
#4 Updated by intrigeri 2019-01-06 11:29:52
- Status changed from In Progress to Resolved
- Assignee deleted (
intrigeri) - % Done changed from 50 to 100
- QA Check changed from Ready for QA to Pass
Output LGTM!
#5 Updated by lamby 2019-01-06 11:49:08
Great; thanks.
See also — https://salsa.debian.org/reproducible-builds/diffoscope/commit/21e4c1ddadbfd79ba2c2d39eaa05671645e43500 that was comitted for this (!)
#6 Updated by intrigeri 2019-01-06 11:52:02
> See also — https://salsa.debian.org/reproducible-builds/diffoscope/commit/21e4c1ddadbfd79ba2c2d39eaa05671645e43500 that was written for this (!)
We’re using diffoscope/stretch-backports on our Jenkins so we should benefit from this soon :)