Bug #16240

proofread/review test.mdwn

Added by CyrilBrulebois 2018-12-22 23:05:32 . Updated 2019-08-30 20:34:02 .

Status:
Resolved
Priority:
Normal
Assignee:
CyrilBrulebois
Category:
Target version:
Start date:
2018-12-22
Due date:
% Done:

0%

Feature Branch:
Type of work:
Contributors documentation
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

While preparing 3.11, I noticed the “It’s design” typo in wiki/src/contribute/release_process/test.mdwn so I took another look later.

Also “such is” → “such as”.

I’ve noticed the ifconfig | grep inet | grep -v inet6 | cut -d" " -f2 | tail -n1 instruction which can’t work since we don’t have net-tools in Tails, and I’ve checked that there’s no ifconfig wrapper. I’m getting an empty string on stretch anyway…

What about this? ip a|awk '/inet / {print $2}' | tail -n1 We get an extra subnet mask though, e.g. 10.0.2.15/24 but 1. it can be sed’d out, and 2. that’s still better than “ifconfig: command not found”?

Also:

  1. Then check that email's headers once received, especially the
     `Received:` one.

one→ones? (There are likely several of them.)

Also I don’t really understand what is meant here: «  * Call the upgrader must be called, […] ”

Also double is here: “The goal is is to check”.

I’m attaching a partial patch for the issues that seem obvious to me.

Files

0001-release_process-test-fix-some-typos.patch (1847 B) CyrilBrulebois, 2018-12-22 23:05:22

Subtasks

History

#1 Updated by mercedes508 2018-12-23 17:16:22

  • Status changed from New to Confirmed

#2 Updated by CyrilBrulebois 2019-01-02 18:06:23

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|6a5aaa6c4f8851f1138ec4cdce0eeda4f8cdee93.

#3 Updated by intrigeri 2019-01-02 18:11:24

  • Assignee set to CyrilBrulebois
  • QA Check set to Ready for QA

> I’ve noticed the ifconfig | grep inet | grep -v inet6 | cut -d" " -f2 | tail -n1 instruction

It’s not a command testers must run: it’s literally what the website should display. Clarified with commit:910fc89b7598a53ea253b1cbf0327c73debbf64b to avoid confusion.

>

>   1. Then check that email's headers once received, especially the
>      `Received:` one.
>

> one→ones? (There are likely several of them.)

This will probably go away with Bug #15914 but still, fixed with commit:01f1c3390ab739e8af79e968ea1b64aa5fe3a8ed.

> Also I don’t really understand what is meant here: «  * Call the upgrader must be called, […] ”

commit:bcbe9050d2f83ef3e1f86afc57e6492041ae804c

> I’m attaching a partial patch for the issues that seem obvious to me.

Applied, thanks!

Please review my fixes, which I pushed straight to the master branch given how trivial that was.

#4 Updated by intrigeri 2019-06-02 14:42:57

  • Status changed from In Progress to Needs Validation

#5 Updated by intrigeri 2019-08-30 20:34:03

  • Status changed from Needs Validation to Resolved

I’ve seen no issue reported since these changes were made 8 months ago, so I’ll assume that’s good enough.