Feature #16234

add option for excludes to our backupscript

Added by groente 2018-12-18 18:51:00 . Updated 2019-02-26 13:09:55 .

Status:
Resolved
Priority:
Normal
Assignee:
groente
Category:
Infrastructure
Target version:
Tails_3.13
Start date:
2018-12-18
Due date:
% Done:

100%

Feature Branch:
Type of work:
Sysadmin
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

the current backup script backs up the entire lv, we need a way to add exclude patterns.

Subtasks

History

#1 Updated by groente 2018-12-18 19:29:24

  • Assignee changed from groente to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to puppet-tails:feature/16234-excludes-for-backups

hey, can you see if this approach makes sense to you?

#2 Updated by intrigeri 2019-01-21 11:07:52

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to groente
  • % Done changed from 0 to 60
  • QA Check deleted (Ready for QA)
  • This approach looks good to me. I’m curious to see the first example of real world usage, I think this will inform my assessement, so please deploy and start using it after taking care of what follows, then reassign to me for QA :)
  • no need to test for "$EXCFILE" existence since you’re calling rm -f
  • I’m suspicious of /usr/bin/borg "${BORGOPTS}" create when $BORGOPTS is empty: it’ll pass an additional (empty string) argument to borg, which might not like it. This might be a case when we need to remove quotes here, and ensure stuff is quoted in $BORGOPTS itself, e.g. BORGOPTS="--exclude-from '${EXCFILE}"'. I’m not 100% sure. Testing will tell.

#3 Updated by anonym 2019-01-30 11:59:23

  • Target version changed from Tails_3.12 to Tails_3.13

#4 Updated by groente 2019-02-26 13:07:54

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 100
  • Feature Branch deleted (puppet-tails:feature/16234-excludes-for-backups)

done