Bug #16213

user module raises warning about real_gid

Added by groente 2018-12-10 13:14:23 . Updated 2018-12-11 10:09:51 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Infrastructure
Target version:
Tails_3.11
Start date:
2018-12-10
Due date:
% Done:

100%

Feature Branch:
puppet-user:bugfix/16213-warning-about-real_gid
Type of work:
Sysadmin
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

stone complains with:

Warning: Unknown variable: ‘real_gid’. at /etc/puppet/code/modules/user/manifests/managed.pp:139:8

Subtasks

Related issues

Blocks Tails - Feature #13284: Core work: Sysadmin (Adapt our infrastructure) Confirmed 2017-06-30

History

#1 Updated by groente 2018-12-10 13:18:05

  • Assignee changed from groente to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to puppet-user:bugfix/16213-warning-about-real_gid

like this real_gid will be declared under all possible conditions, so conditionals on real_gid lateron will not be stuck with an unknown variable.

#2 Updated by intrigeri 2018-12-10 19:31:59

  • Target version changed from Tails_3.11 to Tails_3.12

#3 Updated by intrigeri 2018-12-11 10:00:01

  • blocks Feature #13284: Core work: Sysadmin (Adapt our infrastructure) added

#4 Updated by intrigeri 2018-12-11 10:09:51

  • Status changed from Confirmed to Resolved
  • Assignee deleted (intrigeri)
  • Target version changed from Tails_3.12 to Tails_3.11
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

Merged!

I’ve checked what upstream could be. https://gitlab.com/shared-puppet-modules-group/user/ is archived so forget it. Among the remotes I have for this module, only the immerda one has more recent changes than our version. And interestingly, they’ve applied the exact same fix already: https://git.puppet.immerda.ch/module-user/commit/?id=1e3c0ff2d543f798b938dc3897bba3b74af6f36e.