Bug #16206

Consider dropping CSS hack for uBlock Origin sidebar

Added by intrigeri 2018-12-08 09:14:12 . Updated 2019-05-06 18:15:42 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.13.2
Start date:
2018-12-08
Due date:
% Done:

100%

Feature Branch:
bugfix/16206-drop-ublock-origin-css-hack
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

This:

ublock-origin (1.17.0+dfsg-1) unstable; urgency=medium

  * Add do-not-open-sidebar-on-first-start.patch and prevent that the sidebar
    in Firefox opens on first startup. This feature only works in
    Firefox >= 62. (Closes: #909493)

… should allow us to revert commit:3fc4fb4757222e5bf494eb41801862ba8d0b80c5 and commit:e945d0c9dd331bf63edc576ace154df4aaff19a1, which should in turn fix Bug #15924 (our Tor Browser exposes a different screen size than a pristine one).

Subtasks

Related issues

Related to Tails - Bug #15820: Ublock Log window is empty, need right-click to display logs Resolved 2018-08-20
Related to Tails - Bug #16973: Drop CSS hack for uBlock Origin sidebar Rejected
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by intrigeri 2018-12-08 09:14:18

  • blocked by #16047 added

#2 Updated by intrigeri 2018-12-08 09:14:26

#3 Updated by intrigeri 2018-12-08 09:17:06

  • blocked by deleted (Feature #15507: Core work 2019Q1: Foundations Team)

#4 Updated by intrigeri 2018-12-08 09:17:09

  • blocks deleted (#16047)

#5 Updated by intrigeri 2018-12-08 09:20:52

#6 Updated by intrigeri 2018-12-08 09:21:00

  • Target version deleted (Tails_3.13)

#7 Updated by intrigeri 2019-02-09 08:03:42

And later on:

ublock-origin (1.18.2+dfsg-2) unstable; urgency=medium

  * Drop do-not-open-sidebar-on-first-start.patch. Fixed upstream.

#8 Updated by intrigeri 2019-02-09 08:05:12

  • related to Bug #15820: Ublock Log window is empty, need right-click to display logs added

#9 Updated by intrigeri 2019-03-20 14:43:30

#10 Updated by intrigeri 2019-03-20 14:44:03

  • blocked by deleted (Feature #16210: Core work 2019Q3: Foundations Team)

#11 Updated by segfault 2019-04-03 21:37:55

I don’t think that commit:3fc4fb4757222e5bf494eb41801862ba8d0b80c5 is related

#12 Updated by segfault 2019-04-03 21:50:46

  • Target version set to Tails_3.14
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16206-drop-ublock-origin-css-hack

It seems like we can safely drop commit:e945d0c9dd331bf63edc576ace154df4aaff19a1. I tested this by removing the lines of the commit in /etc/tor-browser/profile/chrome/userChrome.css inside a Tails 3.13.1 before starting Tor Browser for the first time. It did not open the sidebar.

#13 Updated by hefee 2019-04-05 11:14:55

  • Assignee set to hefee

#14 Updated by hefee 2019-04-05 16:37:39

  • Assignee changed from hefee to segfault
  • QA Check changed from Ready for QA to Pass

Change looks fine for me. 3fc4fb4757222e5bf494eb41801862ba8d0b80c5 is not related to this. it passes the test suite and my manual test.

So ready for merge. As I don’t have merge permissions, I reassign back to you.

#15 Updated by segfault 2019-04-05 17:30:06

  • Status changed from Confirmed to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|8c7d9c4217fd6bd9e4fd104aeadfb03e4c945b91.

#16 Updated by segfault 2019-04-05 17:34:19

  • Assignee deleted (segfault)

hefee wrote:
> Change looks fine for me. 3fc4fb4757222e5bf494eb41801862ba8d0b80c5 is not related to this. it passes the test suite and my manual test.
>
> So ready for merge. As I don’t have merge permissions, I reassign back to you.

Done, thanks!

#17 Updated by intrigeri 2019-05-05 08:24:00

  • Target version changed from Tails_3.14 to Tails_3.13.2

#18 Updated by anonym 2019-05-06 15:00:31

  • Status changed from Fix committed to Resolved

#19 Updated by anonym 2019-05-06 15:03:17

  • Target version changed from Tails_3.13.2 to Tails_3.14

#20 Updated by intrigeri 2019-05-06 18:15:42

  • Target version changed from Tails_3.14 to Tails_3.13.2

#21 Updated by segfault 2019-08-11 21:08:43

  • related to Bug #16973: Drop CSS hack for uBlock Origin sidebar added