Feature #16195

Warn about free software also when the host OS might not be free

Added by sajolida 2018-12-06 20:03:12 . Updated 2018-12-16 13:26:03 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Virtualization
Target version:
Tails_3.11
Start date:
2018-12-06
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

See Bug #16117#note-5.

Files

0001-Warn-about-free-software-also-when-the-host-OS-might.patch (1823 B) sajolida, 2018-12-06 20:04:58

Subtasks

History

#1 Updated by sajolida 2018-12-06 20:05:10

Here is a patch (untested).

#2 Updated by intrigeri 2018-12-07 08:37:15

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri
  • Target version changed from Tails_3.12 to Tails_3.11

This was pushed straight to the master branch already (commit:2bdec3e1a7d08ffe615de61811982d2c86e97197) so unless we revert it, it’ll be in 3.11. The proposed change seems simple enough so I’ll review this in time for 3.11 :)

#3 Updated by intrigeri 2018-12-07 09:36:04

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|7e82843e584395bcb36261ee320e373d999a569e.

#4 Updated by intrigeri 2018-12-07 09:37:10

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Yeah, so nowadays I write Ruby and you write Perl ;)

Added a polishing commit on top, tested in libvirt/qemu, merged into stable, then merged into devel, resolved merge conflicts, pushed master + stable + devel.

#5 Updated by sajolida 2018-12-07 20:33:07

> This was pushed straight to the master branch already (commit:2bdec3e1a7d08ffe615de61811982d2c86e97197)

Oh shiiit! I’ve always been afraid of doing something like this and …
I did it without even noticing :(((

Glad you saw it!

—
sajolida

#6 Updated by intrigeri 2018-12-07 20:46:27

>> This was pushed straight to the master branch already (commit:2bdec3e1a7d08ffe615de61811982d2c86e97197)

> Oh shiiit! I’ve always been afraid of doing something like this and …
> I did it without even noticing :(((

That’s fine, shit happens, and we had the option to revert.

#7 Updated by CyrilBrulebois 2018-12-16 13:26:03

  • Status changed from Fix committed to Resolved