Bug #16193

Upgrade Tor Browser to 8.0.4

Added by intrigeri 2018-12-06 15:59:42 . Updated 2018-12-16 13:21:12 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_3.11
Start date:
2018-12-06
Due date:
% Done:

100%

Feature Branch:
feature/16193-tor-browser-8.0.4
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

https://mailman.boum.org/pipermail/tails-dev/2018-December/012379.html

Subtasks

Related issues

Blocks Tails - Feature #15506: Core work 2018Q4: Foundations Team Resolved 2018-04-08

History

#1 Updated by intrigeri 2018-12-06 15:59:50

#2 Updated by intrigeri 2018-12-06 16:00:59

(Filing this mostly for FT accounting purposes and you’ll need a ticket anyway to get reproducible build testing on Jenkins. I don’t know how you’ve decided you would share this work so adding both as watchers.)

#3 Updated by anonym 2018-12-07 12:44:09

  • Assignee changed from CyrilBrulebois to anonym

#4 Updated by anonym 2018-12-07 13:22:13

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|aa1a936c299f5fc4cac463fb3b947a2d2e6cdf94.

#5 Updated by anonym 2018-12-07 15:49:56

  • % Done changed from 0 to 30
  • Feature Branch set to feature/16193-tor-browser-8.0.4

Imported! Next up, tests.

#6 Updated by intrigeri 2018-12-07 17:13:29

> Feature Branch set to feature/16193-tor-browser-8.0.4

> Imported! Next up, tests.

In passing, if our doc does not say so yet, it would be nice if it could tell to add the +force-all-tests suffix to the branch name, since most of the Tor Browser tests won’t run on Jenkins otherwise. I’ve done this recently in wiki/src/contribute/Linux_kernel.mdwn, hoping it’ll save us time :)

#7 Updated by CyrilBrulebois 2018-12-08 12:14:28

I did that yesterday but still waiting on the results.

  • test_Tails_ISO_feature-16193-tor-browser-8.0.4 is OK
  • test_Tails_ISO_feature-16193-tor-browser-8.0.4-force-all-tests isn’t done yet.

#8 Updated by anonym 2018-12-08 20:10:45

  • Assignee changed from anonym to CyrilBrulebois
  • % Done changed from 30 to 50
  • QA Check set to Ready for QA

CyrilBrulebois wrote:
> * test_Tails_ISO_feature-16193-tor-browser-8.0.4-force-all-tests isn’t done yet.

It now is: https://jenkins.tails.boum.org/job/test_Tails_ISO_feature-16193-tor-browser-8.0.4-force-all-tests/1/

None of the transient failures involves the Tor Browser in any way, so we’re good!

Please review’n’merge!

#9 Updated by anonym 2018-12-09 21:13:52

On XMPP intrigeri offered to take this one over to lighten our RM’s burden tomorrow, just so that’s clear. I’ll still assign it to the RM so it cannot be forgotten!

#10 Updated by intrigeri 2018-12-10 08:36:13

  • Assignee changed from CyrilBrulebois to intrigeri

#11 Updated by intrigeri 2018-12-10 08:47:58

Code review passes. I’ve verified that no -build3 is around and I assume you’ve checked with the Tor Browser folks that it’s not planned. I confirm that the test suite failures happen on other +force-all-tests branches on Jenkins. Going to merge!

#12 Updated by intrigeri 2018-12-10 08:48:48

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:tails|dc1a6d6d28388115a2fdee5d84921c59bf25655b.

#13 Updated by intrigeri 2018-12-10 09:01:03

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#14 Updated by CyrilBrulebois 2018-12-16 13:21:12

  • Status changed from Fix committed to Resolved