Bug #16176

create-usb-image-from-iso does not work anymore as non-root

Added by intrigeri 2018-12-01 15:16:11 . Updated 2018-12-02 15:00:00 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.11
Start date:
2018-12-01
Due date:
% Done:

100%

Feature Branch:
feature/15292-generate-usb-image
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
316

Description

By mistake I’ve run the script as non-root and I see:

INFO:__main__:Executing 'mlabel -i /dev/loop0p1 -N a69020d2 ::Tails'
Can't open /dev/loop0p1: Permission denied

Adding as_root=True is not enough because pkexec will filter out the MTOOLS_SKIP_CHECK environment variable.

IIRC the only reason why we’ve kept this code is that you wanted to run it this way. Is this still the case? The fact we’ve introduced a regression without spotting it suggests it’s not. I don’t care much personally about the support for running this script as non-root, but if we keep the corresponding code, then IMO it must be tested and maintained, otherwise we should just drop it, which would be an acceptable resolution for this ticket IMO.

Subtasks

History

#1 Updated by segfault 2018-12-01 15:47:30

  • Feature Branch set to feature/15292-generate-usb-image

Fine, I dropped the non-root support.

#2 Updated by segfault 2018-12-01 15:55:45

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA

#3 Updated by intrigeri 2018-12-02 09:46:02

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 90
  • QA Check changed from Ready for QA to Pass

Thank you. Code review passes. I’ll merge into master→stable→devel at the same time as the changes for Bug #16168.

#4 Updated by intrigeri 2018-12-02 14:59:20

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Applied in changeset commit:tails|1dcb842386538b5c779fa982de4065b2c92e64ba.

#5 Updated by intrigeri 2018-12-02 15:00:00

  • Assignee deleted (intrigeri)