Bug #16159

reproducibly_build_Tails_ISO_* jobs are broken

Added by intrigeri 2018-11-28 07:31:27 . Updated 2018-11-29 13:36:01 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Continuous Integration
Target version:
Tails_3.11
Start date:
2018-11-28
Due date:
% Done:

100%

Feature Branch:
puppet-tails:feature/always-try-to-reproduce-15985
Type of work:
Sysadmin
Blueprint:

Starter:
Affected tool:
Deliverable for:
316

Description

Since the .img is not reproducible and diffoscope does not know any clever way to tell why, it falls back to binary diff and ends up dying because it cannot allocate memory.

For now I we should:

  1. skip comparing the .img file except for feature/15985-reproducible-usb-image
  2. file a ticket so that we revert this once Bug #15985 is resolved and the corresponding code is merged into master→stable→devel

Subtasks

Related issues

Related to Tails - Bug #16162: Test reproducibility of USB images for all branches Resolved 2018-11-28
Related to Tails - Bug #16174: reproducibly_build_Tails_ISO_* jobs leave *.img around even when successful Resolved 2018-11-30

History

#1 Updated by groente 2018-11-28 11:05:46

  • Status changed from Confirmed to In Progress
  • Assignee changed from groente to intrigeri
  • % Done changed from 0 to 30
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16159-reproducibly-build-jobs-broken

#2 Updated by intrigeri 2018-11-28 11:34:41

  • Assignee changed from intrigeri to groente
  • % Done changed from 30 to 80
  • QA Check deleted (Ready for QA)

LGTM; I’ve fixed indentation. Feel free to merge, deploy and then file the aforementioned ticket to revert this :)

#3 Updated by groente 2018-11-28 11:42:58

  • related to Bug #16162: Test reproducibility of USB images for all branches added

#4 Updated by groente 2018-11-28 11:43:36

  • Status changed from In Progress to Resolved
  • Target version deleted (Tails_3.11)
  • % Done changed from 80 to 100

merged & deployed!

#5 Updated by intrigeri 2018-11-28 12:41:34

  • Status changed from Resolved to In Progress
  • Assignee changed from groente to intrigeri
  • Target version set to Tails_3.11
  • QA Check set to Ready for QA

I’ll check how it fares in practice for the next such jobs that Jenkins runs.

#6 Updated by intrigeri 2018-11-28 13:05:24

  • Assignee changed from intrigeri to groente
  • Feature Branch changed from bugfix/16159-reproducibly-build-jobs-broken to feature/always-try-to-reproduce-15985

While we’re at it, I’ve prepared a branch that enforces reproducibility testing of feature/15985-reproducible-usb-image, which will avoid artificially marking its ticket “Ready for QA”. Please review & merge :)

#7 Updated by intrigeri 2018-11-28 16:48:41

  • Feature Branch changed from feature/always-try-to-reproduce-15985 to puppet-tails:feature/always-try-to-reproduce-15985

groente wrote:
> merged & deployed!

In the logs I see: 14:57:01 + [ origin/stable = feature/15985-reproducible-usb-image ]. So I don’t think the comparison works as planned. I’ve pushed a tentative fix to the topic branch.

#8 Updated by groente 2018-11-28 17:31:10

  • Assignee changed from groente to intrigeri

added a little bit of debugging to check if we got the value of GIT_BRANCH right, let me know how it fairs!

#9 Updated by intrigeri 2018-11-29 07:25:49

> added a little bit of debugging to check if we got the value of GIT_BRANCH right,

That’s not necessary since this script is running under set -x: the example comparison I pasted yesterday came straight from the Jenkins job console output. Anyway, it does no harm so I’m leaving it as-is.

#10 Updated by intrigeri 2018-11-29 07:27:42

  • % Done changed from 100 to 90

#11 Updated by intrigeri 2018-11-29 13:36:01

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 90 to 100
  • QA Check changed from Ready for QA to Pass

#12 Updated by intrigeri 2018-11-30 07:35:40

  • related to Bug #16174: reproducibly_build_Tails_ISO_* jobs leave *.img around even when successful added