Bug #16124

URLs without explicit .html are not redirected anymore

Added by sajolida 2018-11-13 20:20:16 . Updated 2018-11-15 17:59:26 .

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
Infrastructure
Target version:
Tails_3.11
Start date:
2018-11-13
Due date:
% Done:

100%

Feature Branch:
Type of work:
Sysadmin
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

To reproduce:

This is a regression, probably coming from self-hosting our website, and it’s affecting the donation campaign (and probably other things), so marking as “High”.

Files

funky-download.png (169512 B) sajolida, 2018-11-13 20:21:59

Subtasks

Related issues

Related to Tails - Feature #14588: Self-host our website Resolved 2018-10-03
Related to Tails - Bug #16220: Website's "add trailing slash" trick is partly broken Resolved 2018-12-11
Has duplicate Tails - Bug #16127: Website install/ broken Duplicate 2018-11-14
Blocks Tails - Feature #13284: Core work: Sysadmin (Adapt our infrastructure) Confirmed 2017-06-30

History

#1 Updated by sajolida 2018-11-13 20:22:08

I spotted this while release Tails Verification 1.2. It give a funky look to https://tails.boum.org/install/download. See attachment :)

#2 Updated by Anonymous 2018-11-14 18:28:35

  • related to Bug #16127: Website install/ broken added

#3 Updated by Anonymous 2018-11-14 18:28:49

  • related to deleted (Bug #16127: Website install/ broken)

#4 Updated by Anonymous 2018-11-14 18:28:50

  • has duplicate Bug #16127: Website install/ broken added

#5 Updated by Anonymous 2018-11-14 18:30:36

Also see Bug #16127: /install has the same issue.

But there are also other problems, like some CSS files are not found (assistant.css results in a 404). That’s why the page looks funky.

#6 Updated by Anonymous 2018-11-14 18:32:13

I’ve sent a mail to sysadmins this morning already, and now told them about this bug, so that they can find more info about the issue. I think intrigeri is not available today btw.

#7 Updated by groente 2018-11-14 19:39:16

i’m seeing gateway timeouts on the ping command:

- [14/Nov/2018:18:52:06 +0000] “GET /ikiwiki.cgi?do=ping HTTP/1.1” 504 183 “-” “curl/7.52.1”

that’s likely to be related

#8 Updated by intrigeri 2018-11-14 19:43:06

  • Priority changed from High to Urgent
  • Target version set to Tails_3.11

#9 Updated by groente 2018-11-14 20:00:31

set the timeout higher, and indeed the ping command was taking longer than the old limit, but manages to finish now.

#10 Updated by groente 2018-11-14 20:03:24

https://tails.boum.org/install/download/ renders fine, whereas https://tails.boum.org/install/download does not, something about the trailing slash is a bit fucky..

#11 Updated by groente 2018-11-14 21:34:49

  • Assignee changed from intrigeri to sajolida
  • QA Check set to Ready for QA

added a rewrite to force trailing slashes in the nginx config, i believe the problem is now fixed, can you confirm?

#12 Updated by intrigeri 2018-11-15 09:04:59

sajolida wrote:
> because they point 1 parent level too high (eg. https://tails.boum.org/donate.js instead of https://tails.boum.org/donate/donate.js).

Given:

$ ls wiki/src/donate*.js   
wiki/src/donate-banner.js  wiki/src/donate.js

I don’t understand why you would expect links to point to https://tails.boum.org/donate/donate.js and still work, but whatever, I trust y’all there’s a bug and I’m on it: will check if groente’s fix is OK.

#13 Updated by intrigeri 2018-11-15 09:05:21

  • Assignee changed from sajolida to intrigeri

#14 Updated by intrigeri 2018-11-15 09:45:46

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to groente
  • % Done changed from 0 to 50

Cleaned up the regexp as discussed over XMPP, the fix still seems to work. Please review :)

#15 Updated by intrigeri 2018-11-15 09:45:55

#16 Updated by intrigeri 2018-11-15 09:46:21

  • blocks Feature #13284: Core work: Sysadmin (Adapt our infrastructure) added

#17 Updated by groente 2018-11-15 09:56:09

  • Assignee changed from groente to intrigeri
  • QA Check changed from Ready for QA to Pass

yep, that should do the trick aswell!

#18 Updated by intrigeri 2018-11-15 17:59:26

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 50 to 100

#19 Updated by intrigeri 2018-12-11 18:28:42

  • related to Bug #16220: Website's "add trailing slash" trick is partly broken added