Bug #16110

Button to remove package in ASP GUI has a wrong label

Added by bertagaz 2018-11-08 16:27:50 . Updated 2019-03-20 14:27:58 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Accessibility
Target version:
Tails_3.13
Start date:
2018-11-08
Due date:
% Done:

100%

Feature Branch:
bugfix/16110-asp-remove-button-label
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
319

Description

While finishing the test suite for ASP, we noticed in Feature #14596#note-54 that for screen readers and accessibility technologies, the “x” button in ASP GUI to remove a package from the list is labeled “close”, which does not fit with the design.

Subtasks

Related issues

Related to Tails - Bug #15838: Fix non-blocking issues identified during ASP code review Resolved 2018-09-26
Blocked by Tails - Bug #16226: Most branches FTBFS on Jenkins since the 3.11 release Resolved 2018-12-15

History

#1 Updated by bertagaz 2018-11-08 16:28:09

  • related to Bug #15838: Fix non-blocking issues identified during ASP code review added

#2 Updated by alant 2018-12-09 16:29:42

  • Category set to Accessibility
  • Status changed from Confirmed to In Progress
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16110-asp-remove-button-label

#3 Updated by intrigeri 2018-12-10 09:03:17

  • Target version changed from Tails_3.11 to Tails_3.12

Too late for 3.11.

#4 Updated by alant 2018-12-16 17:10:46

  • blocked by Bug #16226: Most branches FTBFS on Jenkins since the 3.11 release added

#5 Updated by alant 2019-01-08 19:01:32

  • Assignee changed from alant to segfault

Feel free to assign to someone else to review if you can’t.

#6 Updated by segfault 2019-01-10 22:48:04

  • Assignee changed from segfault to alant
  • QA Check changed from Ready for QA to Pass

Code review passes. I don’t think it’s worth the time to test this again if you already tested it.

#7 Updated by anonym 2019-01-30 11:59:20

  • Target version changed from Tails_3.12 to Tails_3.13

#8 Updated by alant 2019-03-03 16:26:39

  • Assignee changed from alant to anonym

#9 Updated by intrigeri 2019-03-04 11:25:35

  • Assignee changed from anonym to intrigeri

I guess this will require updating the test suite accordingly. Given I’ll work on this part of the test suite soon, I can as well take this one.

#10 Updated by intrigeri 2019-03-04 11:48:19

  • Assignee changed from intrigeri to anonym

#11 Updated by anonym 2019-03-04 11:53:55

  • Assignee changed from anonym to intrigeri

#12 Updated by intrigeri 2019-03-04 13:44:38

  • Subject changed from Improve ASP code: button to remove package in ASP GUI has a wrong label to Button to remove package in ASP GUI has a wrong label

#13 Updated by intrigeri 2019-03-04 13:45:56

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|4ecaedbad70ea697b5bad441935a03d45580f500.

#14 Updated by intrigeri 2019-03-04 13:47:13

  • Status changed from Fix committed to In Progress

Applied in changeset commit:tails|3f1f1b0ecb1c3790fafbf835d3532bb492bff280.

#15 Updated by intrigeri 2019-03-04 13:47:49

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)

Merged and updated the test suite on the Feature #14596 branch.

#16 Updated by CyrilBrulebois 2019-03-20 14:27:58

  • Status changed from Fix committed to Resolved