Bug #16069

"Only the expected addons are installed" Thunderbird test is buggy

Added by intrigeri 2018-10-23 13:08:03 . Updated 2019-04-05 16:11:43 .

Status:
Confirmed
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Start date:
2018-10-23
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Email Client
Deliverable for:

Description

The tentative 3.10 ISO had Enigmail disabled but this test passed.

Files

thunderbird-accerciser.png (92578 B) CyrilBrulebois, 2018-10-23 14:31:05

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by CyrilBrulebois 2018-10-23 13:10:21

How could it work?

    @thunderbird_addons.child('TorBirdy', roleName: 'label')

#2 Updated by CyrilBrulebois 2018-10-23 14:30:20

So the idea is finding the TorBirdy entry in the list of extensions, and checking all of the required ones are there (TorBirdy and Enigmail at the moment). Unfortunately, that doesn’t account for disabled extensions.

Some leads out of the blue:

  • detect the incompatibility banner
  • detect the “disabled” string (but that’s language specific so not hugely practical, and subject to change)
  • detect the “disable” button, which doesn’t appear when the extension is disabled/incompatible.

Maybe more robust:

  • check whether the “disabled” or “incompatible” strings appear anywhere in the children of each considered extension. Invalidate this extension if that happens.

#3 Updated by CyrilBrulebois 2018-10-23 14:32:03

For completeness, attaching a screenshot of accerciser running with Thunderbird from the 3.10 ISO image, so that one gets a glimpse of what the current widget layout look like.

#4 Updated by intrigeri 2018-11-03 07:23:31

  • Priority changed from Normal to Elevated

Given this is about breakage caused by changes in the surrounding ecosystem (major Thunderbird updates breaking add-ons), I think this fits into the limited definition of the test suite maintenance job we have on this year’s budget. So I’ll check how we’re doing wrt. the test suite maintenance budget (keeping in mind that the biggest chunk on our plate this year, i.e. the migration to Buster, will need lots of work): given the trouble this issue has caused us during the 3.10 (sic) release process, it would be nice to fix it.

#5 Updated by intrigeri 2018-11-06 15:44:40

#6 Updated by CyrilBrulebois 2018-11-06 15:45:09

  • Assignee set to CyrilBrulebois

#7 Updated by intrigeri 2019-03-20 14:49:49

#8 Updated by intrigeri 2019-03-20 14:50:01

  • blocked by deleted (Feature #13241: Core work: Test suite maintenance)

#9 Updated by intrigeri 2019-04-05 16:11:43

  • Assignee deleted (CyrilBrulebois)