Bug #16061

Improve ASP code: get rid of search_new_persistence argument

Added by Anonymous 2018-10-16 13:44:03 . Updated 2019-10-09 19:51:57 .

Status:
Confirmed
Priority:
Normal
Assignee:
alant
Category:
Target version:
Start date:
2018-10-16
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Additional Software Packages
Deliverable for:
319

Description

reported from Bug #15838

additionalsoftware.py:

  • get_persistence_path(): only ever called with search_new_persistence=True, return_nonexistent=False
  • has_unlocked_persistence(): only called with search_new_persistence=True

persistence.py:

  • get_persistence_path(): only ever called with search_new_persistence=True, return_nonexistent=False
  • has_unlocked_persistence(): only called with search_new_persistence=True

Subtasks

Related issues

Related to Tails - Bug #15838: Fix non-blocking issues identified during ASP code review Resolved 2018-09-26
Related to Tails - Feature #14568: Additional Software Packages Resolved 2013-12-11 2018-06-26

History

#1 Updated by Anonymous 2018-10-16 13:44:13

  • related to Bug #15838: Fix non-blocking issues identified during ASP code review added

#2 Updated by Anonymous 2018-10-16 13:46:23

  • Subject changed from Improve ASP code: persistence to Improve ASP code: persistence.py
  • Target version set to Tails_3.11

#3 Updated by alant 2018-10-18 18:03:37

  • Subject changed from Improve ASP code: persistence.py to Improve ASP code: get rid of search_new_persistence argument
  • Description updated

#4 Updated by alant 2018-10-18 18:05:07

  • Description updated

#5 Updated by CyrilBrulebois 2018-12-16 14:03:53

  • Target version changed from Tails_3.11 to Tails_3.12

#6 Updated by anonym 2019-01-30 11:59:20

  • Target version changed from Tails_3.12 to Tails_3.13

#7 Updated by Anonymous 2019-03-19 10:55:31

  • Target version changed from Tails_3.13 to Tails_3.14

#8 Updated by Anonymous 2019-05-16 15:05:23

I’m deleting the parent ticket, because I want to close the ASP project. Please let me know when you’ll work on this again, without urgency.

#9 Updated by Anonymous 2019-05-16 15:05:41

#10 Updated by CyrilBrulebois 2019-05-23 21:23:29

  • Target version changed from Tails_3.14 to Tails_3.15

#11 Updated by CyrilBrulebois 2019-07-10 10:34:10

  • Target version changed from Tails_3.15 to Tails_3.16

#12 Updated by intrigeri 2019-08-30 16:21:02

  • Target version changed from Tails_3.16 to Tails_3.17

Too late for 3.16.

#13 Updated by intrigeri 2019-09-12 14:25:21

  • Target version changed from Tails_3.17 to Tails_4.0

#14 Updated by intrigeri 2019-10-09 19:51:57

  • Target version deleted (Tails_4.0)

Last update by Alan was a year ago, and since then the ticket has been postponed by the RM for every release, so I’m removing the Target version info, that seems to communicate no useful information at this point.