Bug #16024

Maybe fix getTorBrowserUserAgent

Added by anonym 2018-10-02 22:21:03 . Updated 2018-12-16 13:22:35 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.11
Start date:
2018-10-03
Due date:
% Done:

100%

Feature Branch:
bugfix/16024-remove-getTorBrowserUserAgent
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

See commit:333e74ae56a67e310dcf6c1a1b6baebca47474ef

Subtasks

Related issues

Blocks Tails - Feature #15506: Core work 2018Q4: Foundations Team Resolved 2018-04-08
Blocked by Tails - Bug #15912: Deal with getTorBrowserUserAgent not being reliable anymore Resolved 2018-09-05

History

#1 Updated by anonym 2018-10-02 22:21:30

#2 Updated by intrigeri 2018-10-03 14:13:16

  • Assignee set to intrigeri

I’ll take a look.

#3 Updated by intrigeri 2018-10-03 14:13:33

  • related to Bug #15912: Deal with getTorBrowserUserAgent not being reliable anymore added

#4 Updated by segfault 2018-10-03 17:47:36

> Let’s just duplicate the Tor Browser user-agent string, which hasn’t
> changed for years (and likely won’t for a loooooong time).

Actually, it did change in Tor Browser 8 and then was reverted in 8.0.2, see https://trac.torproject.org/projects/tor/ticket/26146.

#5 Updated by intrigeri 2018-10-04 20:39:21

I dislike the fact commit:333e74ae56a67e310dcf6c1a1b6baebca47474ef hard-codes a value without setting up a process to update it. But whatever, let’s first discuss on Bug #15912 what we want to do with that script.

#6 Updated by intrigeri 2018-10-04 20:49:15

  • Assignee changed from intrigeri to segfault
  • QA Check set to Info Needed

Same as Bug #15912, I’ll let segfault decide what’s best.

#7 Updated by anonym 2018-10-04 20:56:11

intrigeri wrote:
> I dislike the fact commit:333e74ae56a67e310dcf6c1a1b6baebca47474ef hard-codes a value without setting up a process to update it.

Sorry, I needed a fast solution and thought opening this ticket would be enough as opposed to device a full solution on the spot.

#8 Updated by intrigeri 2018-10-04 21:33:59

> intrigeri wrote:
>> I dislike the fact commit:333e74ae56a67e310dcf6c1a1b6baebca47474ef hard-codes a value without setting up a process to update it.

> Sorry, I needed a fast solution and thought opening this ticket would be enough as opposed to device a full solution on the spot.

Sure, fully understood, and thanks for opening a ticket so this remains on our radar! :)

By the way, just curious: to what problem did this solve?

#9 Updated by anonym 2018-10-04 21:52:24

intrigeri wrote:
> > intrigeri wrote:
> >> I dislike the fact commit:333e74ae56a67e310dcf6c1a1b6baebca47474ef hard-codes a value without setting up a process to update it.
>
> > Sorry, I needed a fast solution and thought opening this ticket would be enough as opposed to device a full solution on the spot.
>
> Sure, fully understood, and thanks for opening a ticket so this remains on our radar! :)

I now realize how defensive I sounded. My intention was just to explain my reasoning, which always is patchable. :)

> By the way, just curious: to what problem did this solve?

It’s pretty bad actually! htpdate (or just its systemd unit file) failed to start with an empty user-agent string set in /etc/default/htpdate.user-agent, which is pretty serious in itself since it breaks parts of our time syncing, but it also breaks all automated tests depending the Tor is ready step (which was how I detected it).

#10 Updated by intrigeri 2018-10-04 22:33:31

> It’s pretty bad actually! htpdate (or just its systemd unit file) failed to start with an empty user-agent string set in /etc/default/htpdate.user-agent, which is pretty serious in itself since it breaks parts of our time syncing, but it also breaks all automated tests depending the Tor is ready step (which was how I detected it).

Aaaah, that’s why htpdate was failing. I somewhat guessed your commit fixed that but I was not sure.

#11 Updated by segfault 2018-10-16 08:58:02

  • related to deleted (Bug #15912: Deal with getTorBrowserUserAgent not being reliable anymore)

#12 Updated by segfault 2018-10-16 08:58:06

  • blocked by Bug #15912: Deal with getTorBrowserUserAgent not being reliable anymore added

#13 Updated by intrigeri 2018-10-17 07:44:15

I think there’ll be nothing to do here once Bug #15912 is merged.

#14 Updated by intrigeri 2018-10-24 17:03:47

  • Target version changed from Tails_3.10.1 to Tails_3.11

#15 Updated by segfault 2018-10-24 20:31:57

  • Status changed from Confirmed to Resolved
  • Assignee deleted (segfault)
  • Target version deleted (Tails_3.11)
  • QA Check deleted (Info Needed)

I think this was solved by Bug #15912, no?

#16 Updated by intrigeri 2018-10-25 08:04:04

  • Status changed from Resolved to In Progress
  • Assignee set to segfault
  • Target version set to Tails_3.11

segfault wrote:
> I think this was solved by Bug #15912, no?

Almost! We’re still shipping getTorBrowserUserAgent but during the manual testing session, it was reported that it does not work anymore => one needs to:

  • check whether this script is still used anywhere and if not, drop it
  • update the corresponding manual test to check that the content of /etc/default/htpdate.user-agent matches Tor Browser’s user agent

#17 Updated by segfault 2018-10-25 19:32:45

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/16024-remove-getTorBrowserUserAgent

> We’re still shipping getTorBrowserUserAgent

Actually, no, I already removed it in fed6918f2c33cb5abb758ec8aeac009929d7403e.

> update the corresponding manual test to check that the content of /etc/default/htpdate.user-agent matches Tor Browser’s user agent

I did this on the feature branch. I also removed the unzip package, which was needed by getTorBrowserUserAgent, and at least a git grep suggests that it isn’t used anywhere else.

#18 Updated by segfault 2018-10-25 19:39:47

  • Assignee changed from intrigeri to segfault
  • QA Check deleted (Ready for QA)

Let’s see whether the test suite passes without unzip before passing this to QA

#19 Updated by segfault 2018-11-06 15:13:15

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA

test suite passes

#20 Updated by intrigeri 2018-11-07 08:42:12

segfault wrote:
> I also removed the unzip package, which was needed by getTorBrowserUserAgent, and at least a git grep suggests that it isn’t used anywhere else.

Confirmed (grep’ed for each executable shipped by the unzip package, verified that unzip does not pull any dependency on which we ourselves depend).

#21 Updated by intrigeri 2018-11-07 08:44:40

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|c07a205e6addbef0f7e9723f4f24f84ffb59c544.

#22 Updated by intrigeri 2018-11-07 08:45:03

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#23 Updated by CyrilBrulebois 2018-12-16 13:22:35

  • Status changed from Fix committed to Resolved